Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Examples#1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mikeebowen merged 27 commits intodotnet:mainfrommikeebowen:examples
Dec 16, 2021
Merged

Examples#1087

mikeebowen merged 27 commits intodotnet:mainfrommikeebowen:examples
Dec 16, 2021

Conversation

@mikeebowen
Copy link
Collaborator

Update examples to use local references and work with updated API.

Copy link
Member

@twsouthwicktwsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few changes and recommendations for follow ups.

The style looks like it may end up failing the build. Make sure to have no warnings locally, as well as withProjectLoadStyle=All perhttps://github.com/OfficeDev/Open-XML-SDK/blob/main/CONTRIBUTING.md

@mikeebowen
Copy link
CollaboratorAuthor

Made all the requested changes and made the VS linter happy.

Copy link
Collaborator

@ThomasBarnekowThomasBarnekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looked at the examples and provided some comments.

It seems like some of the code was generated, right? Can't help thinking that the Linq-to-XML way of creating markup is more natural in some cases at least.

@twsouthwick
Copy link
Member

@ThomasBarnekow Agreed - it's also less for the JIT to deal with. I'm liking the direction that the XLinq stuff goes as a more lightweight way of building documents. As it matures more it'll be interesting to get feedback on performance/onboarding/maintainability/etc of that pattern.

@twsouthwick
Copy link
Member

@mikeebowen there's a conflict you'll need to deal with

@mikeebowen
Copy link
CollaboratorAuthor

@twsouthwick Please check to make sure I fixed the conflict correctly

@ThomasBarnekow
Copy link
Collaborator

@twsouthwick and@mikeebowen, would you be interested in adding an additional example (now or later) that does the same thing as an existing example (which uses the strongly typed classes) but uses the Linq-to-XML way of creating Open XML markup? I'd be happy to provide that.

mikeebowen reacted with thumbs up emoji

@twsouthwick
Copy link
Member

@ThomasBarnekow I think that would be cool. Once you feel like the shape is right with it, it would be a great chance to see a comparison.

@twsouthwick
Copy link
Member

@mikeebowen looks like you didn't get the merge right (there's still git conflict markers, i.e.<<<<HEAD and such)

twsouthwick
twsouthwick previously approved these changesDec 15, 2021
Copy link
Member

@twsouthwicktwsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mikeebowen This looks good enough for now. Let's keep playing with the structure of the samples and we can probably consolidate some of this.

mikeebowen reacted with thumbs up emoji
twsouthwick
twsouthwick previously approved these changesDec 16, 2021
@mikeebowenmikeebowen merged commitec28405 intodotnet:mainDec 16, 2021
@mikeebowenmikeebowen deleted the examples branchDecember 16, 2021 18:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@twsouthwicktwsouthwicktwsouthwick approved these changes

+1 more reviewer

@ThomasBarnekowThomasBarnekowThomasBarnekow left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikeebowen@twsouthwick@ThomasBarnekow
[8]ページ先頭
©2009-2025 Movatter.jp