Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DotMemoryDiagnoser implementation#2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@martinothamar
Copy link
Contributor

ImplementsDotMemoryDiagnoser to matchDotTraceDiagnoser

  • The code is pretty similar between dotMemory and dotTrace impl, because the underlying APIs/CLIs are similar. Could do something to share code here
    • Is there any reason we can't use thePID config on the APIs for the Jetbrains library directly? I could refactor to use that instead, both for dotTrace and dotMemory
  • Could refactor out common code and either publish aCommon package or just use<Compile Include="..." />

Sample output ofIntroDotMemoryDiagnoser

image

@martinothamar
Copy link
ContributorAuthor

There was a segfault happening for the integration test that I don't quite understand. I can no longer reproduce it after the last commit. I tried to debug some dumps locally but was unable to find relevant exceptions, so my only guess atm is that the crash originates from unmanaged code. Since changing the init logic seemed to affect things, and the crash always happening duringInProcessEmitToolchain, I'm guessing it has something to do with attaching/detaching multiple times in the same process or something

In any case, I would like to test out using only the JetBrains API directly

@martinothamar
Copy link
ContributorAuthor

martinothamar commentedMar 31, 2024
edited
Loading

The last commit simplifies the implementation of the tool by using only the Jetbrains API, and the lifetime of it is more clearly managed based on the incoming signals.

I'd be willing to try the same with dotTrace impl. I also want to make a flag likeperformExtraBenchmarksRun similar to some of the other profilers. I could do these en subsequent PRs

@AndreyAkinshinAndreyAkinshin merged commitc7b7abf intodotnet:masterApr 1, 2024
@AndreyAkinshinAndreyAkinshin added this to thev0.14.0 milestoneApr 1, 2024
@AndreyAkinshin
Copy link
Member

@martinothamar thank you very much for this PR!

@martinothamarmartinothamar deleted the feature/dotMemory-profiler branchApril 1, 2024 15:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AndreyAkinshinAndreyAkinshinAndreyAkinshin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@martinothamar@AndreyAkinshin

[8]ページ先頭

©2009-2025 Movatter.jp