Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds a custom exporter option on command line args#2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nazulg wants to merge2 commits intodotnet:master
base:master
Choose a base branch
Loading
fromnazulg:Add-Custom-Exporter-Option

Conversation

nazulg
Copy link
Contributor

Fix#1967

This code adds the ability to include a custom exporter from command line arguments.

The user can use the option --customExporter "{assembly-qualified name of exporter}" and it will load the exporter into the config.

Please let me know your thoughts on this approach.

Thank you.

@timcassell
Copy link
Collaborator

timcassell commentedNov 8, 2023
edited
Loading

It doesn't make sense to have theRegisterCustomExporter function if you're just going to create it from the type and ignore the registered name. I like being able to use it from the type, but it should also work from the registered name.

Also, the command line option should support multiple values (like--runtimes). And I would prefer--exporters

[Edit] I see--exporters already exists for built-in exporters. Just expand it to support custom types.

nazulg reacted with thumbs up emoji

@nazulg
Copy link
ContributorAuthor

nazulg commentedNov 9, 2023
edited
Loading

I updated the PR based on the comments. In this change, a custom exporter can be added to the existing exporters collection.

If the exporter name is not found in the default list, then it tries to create an exporter from the argument as it will be considered to be a type name using the assembly name.

It is still in progress, let me know what do you think of this approach.

@timcassell
Copy link
Collaborator

timcassell commentedNov 9, 2023
edited
Loading

LGTM, unsure if we do want to support registering custom names (to be able to use simplified names as well as full assembly-qualified types). What do you think@adamsitnik?

nazulg reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timcasselltimcasselltimcassell left review comments

@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom exporter options to be defined
2 participants
@nazulg@timcassell

[8]ページ先頭

©2009-2025 Movatter.jp