Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1k
Adds a custom exporter option on command line args#2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
timcassell commentedNov 8, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It doesn't make sense to have the Also, the command line option should support multiple values (like [Edit] I see |
Uh oh!
There was an error while loading.Please reload this page.
nazulg commentedNov 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I updated the PR based on the comments. In this change, a custom exporter can be added to the existing exporters collection. If the exporter name is not found in the default list, then it tries to create an exporter from the argument as it will be considered to be a type name using the assembly name. It is still in progress, let me know what do you think of this approach. |
timcassell commentedNov 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
LGTM, unsure if we do want to support registering custom names (to be able to use simplified names as well as full assembly-qualified types). What do you think@adamsitnik? |
Fix#1967
This code adds the ability to include a custom exporter from command line arguments.
The user can use the option --customExporter "{assembly-qualified name of exporter}" and it will load the exporter into the config.
Please let me know your thoughts on this approach.
Thank you.