Fix some code quality issues#176

Open

pnijhara wants to merge 1 commit intodonnemartin:masterfrom

pnijhara:pnijhara-patch-1

Open

Fix some code quality issues#176
pnijhara wants to merge 1 commit intodonnemartin:masterfrom
pnijhara:pnijhara-patch-1

Conversation

Copy link

pnijhara commentedApr 11, 2020

Remove unused variables
Fix dangerous default argument
Use literal syntax instead of function calls to create the data structure

Find the other issues found here -https://deepsource.io/gh/pnijhara/gitsome/issues/?category=all

This PR also adds.deepsource.toml configuration file to run DeepSource analysis on the repo with. Upon enabling DeepSource, the analysis will run on every PR and commit to detect 560+ types of issues in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.

To enable DeepSource analysis after merging this PR, please follow these steps:

Signup on DeepSource with your GitHub account and grant access to this repo.
Activate analysis on this repohere.

You can also look at thedocs for more details. Do let me know if I can be of any help!

Copy link

codecov-io commentedApr 11, 2020

Codecov Report

Merging#176 intomaster willdecrease coverage by41.89%.
The diff coverage is42.85%.

@@             Coverage Diff             @@##           master     #176       +/-   ##===========================================- Coverage   95.09%   53.19%   -41.90%===========================================  Files          34       86       +52       Lines        2119     6593     +4474     ===========================================+ Hits         2015     3507     +1492- Misses        104     3086     +2982