Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Python 3.14 test failures#137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gotmax23 wants to merge2 commits intodomdfcoding:master
base:master
Choose a base branch
Loading
fromgotmax23:314

Conversation

@gotmax23
Copy link

See the individual commit messages for more information about each change. This PR was created during the process of bootstrapping Python 3.14 for Fedora Linux.

``` fishfor i in python3.{9,10,11,12,13,14}    echo -n "$i "    $i -c 'import pathlib; print(repr(pathlib.PurePosixPath))'end``````python3.9 <class 'pathlib.PurePosixPath'>python3.10 <class 'pathlib.PurePosixPath'>python3.11 <class 'pathlib.PurePosixPath'>python3.12 <class 'pathlib.PurePosixPath'>python3.13 <class 'pathlib._local.PurePosixPath'>python3.14 <class 'pathlib.PurePosixPath'>```
As ofpython/cpython#121395, the format of thelist.index exception has changed and parsing it like this no longerworks. Relying on implementation details like this is always risky, sothis solution should be more future-proof.
@MeggyCal
Copy link

MeggyCal commentedSep 15, 2025
edited
Loading

Hi, your patch didn't fix my Python 3.14 build, it was also necessary to add one more fix:

Index: domdf_python_tools-3.10.0/tests/test_paths.py===================================================================--- domdf_python_tools-3.10.0.orig/tests/test_paths.py+++ domdf_python_tools-3.10.0/tests/test_paths.py@@ -925,7 +925,7 @@ else: @pytest.mark.parametrize("path", _from_uri_paths)-@pytest.mark.parametrize("left_type", [pathlib.PurePath, pathlib.Path, PathPlus])+@pytest.mark.parametrize("left_type", [pathlib.Path, PathPlus]) def test_pathplus_from_uri(path: str, left_type: Type):        assert PathPlus.from_uri(left_type(path).as_uri()).as_posix() == path

This is not a review, I am just working on Python 3.14 integration in openSUSE and discovered this issue as well.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@domdfcodingdomdfcodingAwaiting requested review from domdfcoding

At least 1 approving review is required to merge this pull request.

Assignees

@domdfcodingdomdfcoding

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gotmax23@MeggyCal@domdfcoding

[8]ページ先頭

©2009-2025 Movatter.jp