Commit9c83f9a

committed

Expired check ALWAYS executes yield policy BEFORE checking expiration - that's wasted time.

Expired keeps executing yield policy on already expired oneShot - that's counter intuitive and wasted time.

1 parent9863f71 commit9c83f9aCopy full SHA for 9c83f9a

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -158,10 +158,9 @@ class timeoutTemplate`
`158`	`158`	`IRAM_ATTR// fast`
`159`	`159`	`boolexpired()`
`160`	`160`	`{`
`161`		`-YieldPolicyT::execute();//in case of DoNothing: gets optimized away`
`162`		`-if(PeriodicT)//in case of false: gets optimized away`
`163`		`-returnexpiredRetrigger();`
`164`		`-returnexpiredOneShot();`
	`161`	`+bool hasExpired = PeriodicT ?expiredRetrigger() :expiredOneShot();`
	`162`	`+if (!hasExpired)YieldPolicyT::execute();//in case of DoNothing: gets optimized away`
	`163`	`+return hasExpired;`
`165`	`164`	`}`
`166`	`165`
`167`	`166`	`IRAM_ATTR// fast`

Comments

(0)