Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support string and number literal types#5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
motiz88 wants to merge2 commits intodocumentationjs:master
base:master
Choose a base branch
Loading
frommotiz88:literal-types

Conversation

motiz88
Copy link

This fixes breakage I've seen when trying to generate HTML documentation from Flow types that contain literal types as their members, (e.g. member types ofdisjoint unions). String and number literals are both supported to match Flow. (Possibly booleans are also needed? The Flow changelog hints at this)

I couldn't figure out how to add proper tests, unfortunately, but the minimal case that used to cause errors is runningdocumentation build --format html on the following two variations of the same code:

/** * A */typeA={tag:'A';};
/** * A */typeA={tag:1;};

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@motiz88

[8]ページ先頭

©2009-2025 Movatter.jp