Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Task/update docs tests failing on master#1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
DavideDaniel wants to merge2 commits intodocumentationjs:master
base:master
Choose a base branch
Loading
fromDavideDaniel:task/update-docs-tests-failing-on-master

Conversation

DavideDaniel
Copy link
Contributor

@DavideDanielDavideDaniel commentedNov 18, 2021
edited
Loading

Results of runningnpm run build and assessingnpm test on master.

On master runningnpm test yields:
image

Update: above was resolved by runningnpm ci first so I dropped the commit to amend tests.

Runningnpm run build results in self documentation breaking:
image
image

@DavideDaniel
Copy link
ContributorAuthor

Why are there differences in CI and local? I'm running node 14.18.1 but locally tests fail due to the additional\\ but in CI I can see it failing from the lack of. Does anyone know?

@anthony-redFox
Copy link
Member

@DavideDaniel you need to update your local packages, just executenpm ci

@DavideDaniel
Copy link
ContributorAuthor

DavideDaniel commentedNov 19, 2021
edited
Loading

On master, on node v14.18.1, rannpm ci and thennpm run build and the command breaks in the midst of parsing own file.
image
image

Investigating underlying issue withkonan@2.1.1 but if you don't have this happening on your end@anthony-redFox , please let me know.

@DavideDaniel
Copy link
ContributorAuthor

The problem is whenkonan parseshttps://github.com/documentationjs/documentation/blob/master/src/output/html.js#L23-L26
The dynamic import statements are not properly evaluated herehttps://github.com/egoist/konan/blob/master/index.js#L40
This is causingnpm run build to break the self documenting, which probably means it would break for others as well.
image

There is an option to disable detecting dynamic imports:https://github.com/egoist/konan#dynamicimport, which does seem to fix the issue.
image

@DavideDanielDavideDanielforce-pushed thetask/update-docs-tests-failing-on-master branch from48c7d80 to8d65e43CompareNovember 19, 2021 06:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DavideDaniel@anthony-redFox

[8]ページ先頭

©2009-2025 Movatter.jp