- Notifications
You must be signed in to change notification settings - Fork486
fix: Update scope to default to static when memberof#1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -22933,12 +22934,13 @@ Array [ | |||
| "static": Array [], | |||
| }, | |||
| "name": "getUndefined", | |||
| "namespace": "MyClass.getUndefined", | |||
| "namespace": ".MyClass.getUndefined", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like this is a regression? Namespaces shouldn't start with..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a strange case. In the testsMyClass is a member ofcom.Test. Howevercom.Test is never defined. Should the name space becom.Test.MyClass.getUndefined? or should it remainMyClass.getUndefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should probably remain asMyClass.getUndefined, and the way we format namespaces should avoid prefixing static scopes with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@tmcw there's currently anamespace on master in the test snapshots that starts with a..
This is the same scenario as above except in this case the static is implied from the syntax tree instead of being assumed based on the@memberof tag.
Addingmemo &&here would remove the leading. in all cases including cases currently in master. Let me know how I should proceed.
fix: Update scope to default to static when memberof
fix#197