Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve docs embed files code fragment#2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jacobsorme wants to merge2 commits intodocsifyjs:develop
base:develop
Choose a base branch
Loading
fromjacobsorme:develop

Conversation

@jacobsorme
Copy link
Contributor

Summary

Improve docs for embed files code fragment.

Related issue, if any:

#2626

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercelbot commentedDec 16, 2025

@jacobsorme is attempting to deploy a commit to theDocsify Team onVercel.

A member of the Team first needs toauthorize it.

@jacobsorme
Copy link
ContributorAuthor

@trusktr Added example (kinda), do you think we need a full example for the:omitFragmentLine? My thoughts was to avoid having the section grow too long

@vercel
Copy link

vercelbot commentedDec 17, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
docsify-previewReadyReadyPreview,CommentDec 17, 2025 2:06am

Copy link
Collaborator

@paulhibbittspaulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this PR@jacobsorme ! I've tested the PR build in codesandbox and it looks to work as described:

https://codesandbox.io/p/devbox/admiring-yonath-qgtfp5?workspaceId=ws_C7CBq2TzamwfU438Zxccyc

I think it would be clearer in the docs to display the file contents on the same page before the embedded fragment:
https://qgtfp5.csb.app/#/fragment-embed

What do you think?

@jacobsorme
Copy link
ContributorAuthor

Good idea I completely agree! Willfix

paulhibbitts reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@paulhibbittspaulhibbittspaulhibbitts left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacobsorme@paulhibbitts
[8]ページ先頭
©2009-2025 Movatter.jp