Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: remove loading dialog section from quickstart guide#2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sy-records merged 1 commit intodocsifyjs:developfromsy-records:docs/quickstart
Aug 7, 2025

Conversation

@sy-records
Copy link
Member

Summary

After merging#1466, I discovered#1458 (comment).

It seems thatdata-app does not currently have any practical use? And there is a newLoading.

Perhapsdata-app is used in Vue. However, I tested it without adding it, and it worked fine.

So I removed this part of the content.

Related issue, if any:

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercelbot commentedJul 30, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬Add feedbackAug 7, 2025 2:34am

Copy link
Member

@Koooooo-7Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the v4, theLoading dialog support customize the Loading content even inserting DOMs.

<divid="app"> I'm loading ...</div>

For now when we change the content, we'll see the loading effect and the content mess up.
I suppose we should have a fix on it...

@sy-records
Copy link
MemberAuthor

Modifying it requires adding some styles.

#app {
display: flex;
align-items: center;
justify-content: center;
gap:0.75em;
height:100vh;
padding-inline:50px;
}

There is a new loading screen in v5. I think we can remove it without fixing it.

@Koooooo-7
Copy link
Member

There is a new loading screen in v5. I think we can remove it without fixing it.

Cuz I thought it was a feature in v4 that user can customize the loading page easily.
I'm ok with it to remove this feature, if user urges to add it back, we could refine it then.

@sy-recordssy-records merged commit4c9e111 intodocsifyjs:developAug 7, 2025
7 of 8 checks passed
@sy-recordssy-records deleted the docs/quickstart branchAugust 7, 2025 02:32
@sy-recordssy-records mentioned this pull requestSep 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sy-records@Koooooo-7
[8]ページ先頭
©2009-2025 Movatter.jp