NotificationsYou must be signed in to change notification settings
Fork5.8k
Star30.6k

docs: update sidebar link formatting#2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Koooooo-7 merged 5 commits intodocsifyjs:developfromsy-records:fix/ptag

Jul 28, 2025

Merged

docs: update sidebar link formatting#2577

Koooooo-7 merged 5 commits intodocsifyjs:developfromsy-records:fix/ptag

Jul 28, 2025

Conversation

Copy link

Member

sy-records commentedJul 24, 2025

Summary

There are some issues with clicking on awesome and changelog.https://preview.docsifyjs.org/#/awesome

The solution is to remove the p tag from the top level<li><p><a></a></p></li>.

Related issue, if any:

What kind of change does this PR introduce?

Bugfix

For any code change,

Related documentation has been updated, if needed
Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

Yes

Tested in the following browsers:

Chrome
Firefox
Safari
Edge

Copy link

vercelbot commentedJul 24, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docsify-preview	✅ Ready (Inspect)	Visit Preview	💬Add feedback	Jul 28, 2025 11:27am

vercelbotdeployed toPreview

July 24, 2025 05:56

View deployment

vercelbotdeployed toPreview

July 24, 2025 06:03

View deployment

Koooooo-7 reviewed

Jul 25, 2025

View reviewed changes

Copy link

Member

Koooooo-7 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the root cause may be the styling since thedisplay:none apply to all the nona elements.
As a single line in_sidebar.md , which does't as a group but a link, we need reconsider how to structure the sidebar and refine the css selector.

docsify/src/themes/shared/_sidebar.css

Line 91 inbe21637

&.collapse {

&.collapse {>:not(a) {display: none;      }    }

cc@jhildenbiddle

Copy link

MemberAuthor

sy-records commentedJul 28, 2025

- [UI Kit](ui-kit.md)- [Awesome docsify](awesome.md)- [Changelog](changelog.md)<ul>  <li><a href="#/ui-kit" title="UI Kit">UI Kit</a></li>  <li><a href="#/awesome" title="Awesome docsify">Awesome docsify</a></li>  <li><a href="#/changelog" title="Changelog">Changelog</a></li></ul>

- Guide  - [UI Kit](ui-kit.md)- [Awesome docsify](awesome.md)- [Changelog](changelog.md)<ul>  <li><p>Guide</p>    <ul>      <li><a href="#/ui-kit" title="UI Kit">UI Kit</a></li>    </ul>  </li>  <li><p><a href="#/awesome" title="Awesome docsify">Awesome docsify</a></p></li>  <li><p><a href="#/changelog" title="Changelog">Changelog</a></p></li></ul>