Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: add stormkit as deployment platform#2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sy-records merged 2 commits intodocsifyjs:developfromeldemcan:patch-1
May 7, 2024

Conversation

@eldemcan
Copy link
Contributor

Summary

Add stormkit as deployment platform

Related issue, if any:

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercelbot commentedApr 29, 2024•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬Add feedbackApr 29, 2024 10:06pm

@paulhibbitts
Copy link
Collaborator

Thanks for the PR@eldemcan . Following the provided instructions resulted in a 404 error - not familiar with StormKit but usually you need to set the folder to be served to 'docs', could you please update the PR with the needed info to do that? Thank you!

@paulhibbittspaulhibbitts self-assigned thisApr 29, 2024
@eldemcan
Copy link
ContributorAuthor

Thanks for the PR@eldemcan . Following the provided instructions resulted in a 404 error - not familiar with StormKit but usually you need to set the folder to be served to 'docs', could you please update the PR with the needed info to do that? Thank you!

Hi@paulhibbitts
Thanks for looking into this PR, I updated step to set output folder todocs.

paulhibbitts reacted with thumbs up emoji

@paulhibbittspaulhibbitts self-requested a reviewApril 30, 2024 14:48
Copy link
Collaborator

@paulhibbittspaulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me.

@paulhibbittspaulhibbitts added the docsrelated to the documentation of docsify itself labelApr 30, 2024
@eldemcan
Copy link
ContributorAuthor

Hi@paulhibbitts, is there anything I need to do before this is merged ?

Copy link
Member

@sy-recordssy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thank you!

@sy-recordssy-records merged commit11015fe intodocsifyjs:developMay 7, 2024
@paulhibbitts
Copy link
Collaborator

Thanks for merging the PR@sy-records!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sy-recordssy-recordssy-records approved these changes

@paulhibbittspaulhibbittsAwaiting requested review from paulhibbitts

Assignees

@paulhibbittspaulhibbitts

Labels

docsrelated to the documentation of docsify itself

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldemcan@paulhibbitts@sy-records
[8]ページ先頭
©2009-2025 Movatter.jp