Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
Feat: Add aria attributes to sidebar toggle button and current page link#2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedOct 9, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
# Conflicts:#src/core/render/tpl.js#test/integration/__snapshots__/docs.test.js.snap
Allow active heading links to also announce “current page”
@Koooooo-7 -- Would you mind approving this PR again? I had to merge |
Uh oh!
There was an error while loading.Please reload this page.
Summary
These updates align with accessibility best practices.
Before
2254-before.mp4
After
2254-after.mp4
Tip: Use built-in screen readers for testing on macOS and Windows
macOS VoiceOver
VoiceOver User Guide
Windows Narrator
Complete guide to Narrator
Related issue, if any:
#658
#2226
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Tested in the following browsers: