Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feat: Add aria attributes to sidebar toggle button and current page link#2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jhildenbiddle merged 20 commits intodevelopfrom658-aria
Nov 30, 2023

Conversation

@jhildenbiddle
Copy link
Member

@jhildenbiddlejhildenbiddle commentedOct 9, 2023
edited
Loading

Summary

These updates align with accessibility best practices.

  1. Add aria attributes to sidebar toggle to indicate expanded/collapsed state
  2. Add aria attributes to indicate current page

Before

  • No indication of current page in sidebar navigation
  • Sidebar toggle does not indicate purpose or current state
2254-before.mp4

After

  • Current page is indicated in sidebar navigation
  • Sidebar toggle indicated purpose and current state
2254-after.mp4

Tip: Use built-in screen readers for testing on macOS and Windows

macOS VoiceOver

VoiceOver User Guide

  1. Turn VoiceOver on. ⌘ + F5
  2. Open the Rotor CTRL + ⌥ + U
  3. Use the ← and → arrow keys until you reach the "Landmark" list.
  4. Navigate the list using the ↑ and ↓ arrow keys.
  5. Press ↵ or SPACE to select to jump to the current item (rotor closes afterwards).

Windows Narrator

Complete guide to Narrator

  1. Press the Windows key + Ctrl + Enter together to start Narrator. Press these keys again to stop Narrator. On many keyboards, the Windows logo key is located on the bottom row of keys, to the left or right of the Alt key.
  2. Press the Windows key + Ctrl + N to open Narrator settings, and then turn on the toggle under Use Narrator.

Related issue, if any:

#658
#2226

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercelbot commentedOct 9, 2023
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬Add feedbackNov 30, 2023 5:28am

@jhildenbiddlejhildenbiddle changed the titleAdd aria attributes to sidebar toggle, search field, and current pageFeat: Add aria attributes to sidebar toggle, search field, and current pageOct 14, 2023
Koooooo-7
Koooooo-7 previously approved these changesNov 17, 2023
# Conflicts:#src/core/render/tpl.js#test/integration/__snapshots__/docs.test.js.snap
Allow active heading links to also announce “current page”
@jhildenbiddlejhildenbiddle changed the titleFeat: Add aria attributes to sidebar toggle, search field, and current pageFeat: Add aria attributes to sidebar toggle, current page, and search elements.Nov 30, 2023
@jhildenbiddlejhildenbiddle changed the titleFeat: Add aria attributes to sidebar toggle, current page, and search elements.Feat: Add aria attributes to sidebar toggle button and current page linkNov 30, 2023
@jhildenbiddle
Copy link
MemberAuthor

@Koooooo-7 --

Would you mind approving this PR again? I had to mergedevelop which cleared your previous approvals. Thx!

Koooooo-7 reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

@sy-recordssy-recordssy-records approved these changes

@trusktrtrusktrAwaiting requested review from trusktr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessibility - current page in sidebar should have aria-current="page" Sidebar button does not have a description useful for screen reader users

5 participants

@jhildenbiddle@trusktr@Koooooo-7@sy-records

[8]ページ先頭

©2009-2025 Movatter.jp