Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

delete SSR#2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
trusktr merged 2 commits intodevelopfromdelete-ssr
Jul 2, 2023
Merged

delete SSR#2105

trusktr merged 2 commits intodevelopfromdelete-ssr
Jul 2, 2023

Conversation

@trusktr
Copy link
Member

@trusktrtrusktr commentedJun 25, 2023
edited
Loading

Part of

Summary

SSR was experimental and incomplete, namely not working with plugins, generally not an ideal way to manage code (duplication of Renderer), and none of us have shown any desire to continue implementing that path.

I have better ideas (discord discussion) on the how to leverage tools like Solid Start,Astro, orQwik.js for SSR and SSG in ways that will be way better than what we had going on.

Note: if we use Astro or Qwik, for example, this opens up the door to allowing people to write not just Vue inside Docsify, but also Solid, React, Svelte, Custom Elements, and more.

So this removes SSR, which we believe is not the ideal way to proceed.

Later, when someone desires and has the time, they can propose a new and complete SSR/SSG implementation that is on a good path, not duplicating a bunch of logic, ideally aligned with modern tech.

Thought leaders from Next.js, Nuxt.js, Solid Start, SvelteKit, and more recently the generic solutions Astro and Qwik, have been ironing out the details of SSR, SSG, CSG for alooooong time; they are masters at it. We should pursue a robust modern solution based on those when we sit down to finally do this.

What kind of change does this PR introduce?

Feature removal: delete SSR.

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Breaking change because someone might be using it. This requires a major version bump.

Related issue, if any:

I am planning to finish a few more things in a row here:

#2104.

We can wait for all of those (except perhaps TypeScript) before releasing a major version bump so that we don't release several major version bumps back to back.

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

adanski reacted with thumbs down emoji
@vercel
Copy link

vercelbot commentedJun 25, 2023
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬Add feedbackJun 30, 2023 2:55am

@trusktrtrusktr requested a review froma teamJune 25, 2023 06:49
@codesandbox-ci
Copy link

codesandbox-cibot commentedJun 25, 2023
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit8d5d204:

SandboxSource
docsify-templateConfiguration

exports[`Docs Site navbar renders and is unchanged 1`] = `"<nav class=\\"app-nav no-badge\\"><ul><li>Translations<ul><li><a href=\\"#/\\" title=\\"undefined\\" class=\\"active\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1ec-1f1e7.png?v8.png\\" alt=\\"uk\\" class=\\"emoji\\" loading=\\"lazy\\"> English</a></li><li><a href=\\"#/zh-cn/\\" title=\\"undefined\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1e8-1f1f3.png?v8.png\\" alt=\\"cn\\" class=\\"emoji\\" loading=\\"lazy\\"> 简体中文</a></li><li><a href=\\"#/de-de/\\" title=\\"undefined\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1e9-1f1ea.png?v8.png\\" alt=\\"de\\" class=\\"emoji\\" loading=\\"lazy\\"> Deutsch</a></li><li><a href=\\"#/es/\\" title=\\"undefined\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1ea-1f1f8.png?v8.png\\" alt=\\"es\\" class=\\"emoji\\" loading=\\"lazy\\"> Español</a></li><li><a href=\\"#/ru-ru/\\" title=\\"undefined\\"><img src=\\"https://github.githubassets.com/images/icons/emoji/unicode/1f1f7-1f1fa.png?v8.png\\" alt=\\"ru\\" class=\\"emoji\\" loading=\\"lazy\\"> Русский</a></li></ul></li></ul></nav>"`;
exports[`Docs Site sidebar renders and is unchanged 1`] = `"<aside class=\\"sidebar\\"><div class=\\"sidebar-nav\\"><ul><li><p>Getting started</p><ul><li><a href=\\"#/quickstart\\" title=\\"undefined\\">Quick start</a></li><li><a href=\\"#/more-pages\\" title=\\"undefined\\">Writing more pages</a></li><li><a href=\\"#/custom-navbar\\" title=\\"undefined\\">Custom navbar</a></li><li><a href=\\"#/cover\\" title=\\"undefined\\">Cover page</a></li></ul></li><li><p>Customization</p><ul><li><a href=\\"#/configuration\\" title=\\"undefined\\">Configuration</a></li><li><a href=\\"#/themes\\" title=\\"undefined\\">Themes</a></li><li><a href=\\"#/plugins\\" title=\\"undefined\\">List of Plugins</a></li><li><a href=\\"#/write-a-plugin\\" title=\\"undefined\\">Write a Plugin</a></li><li><a href=\\"#/markdown\\" title=\\"undefined\\">Markdown configuration</a></li><li><a href=\\"#/language-highlight\\" title=\\"undefined\\">Language highlighting</a></li><li><a href=\\"#/emoji\\" title=\\"undefined\\">Emoji</a></li></ul></li><li><p>Guide</p><ul><li><a href=\\"#/deploy\\" title=\\"undefined\\">Deploy</a></li><li><a href=\\"#/helpers\\" title=\\"undefined\\">Helpers</a></li><li><a href=\\"#/vue\\" title=\\"undefined\\">Vue compatibility</a></li><li><a href=\\"#/cdn\\" title=\\"undefined\\">CDN</a></li><li><a href=\\"#/pwa\\" title=\\"undefined\\">Offline Mode (PWA)</a></li><li><a href=\\"#/ssr\\" title=\\"undefined\\">Server-Side Rendering (SSR)</a></li><li><a href=\\"#/embed-files\\" title=\\"undefined\\">Embed Files</a></li></ul></li><li><p><a href=\\"#/awesome\\" title=\\"undefined\\">Awesome docsify</a></p></li><li><p><a href=\\"#/changelog\\" title=\\"undefined\\">Changelog</a></p></li></ul></div></aside>"`;
exports[`Docs Site sidebar renders and is unchanged 1`] = `"<aside class=\\"sidebar\\"><div class=\\"sidebar-nav\\"><ul><li><p>Getting started</p><ul><li><a href=\\"#/quickstart\\" title=\\"undefined\\">Quick start</a></li><li><a href=\\"#/more-pages\\" title=\\"undefined\\">Writing more pages</a></li><li><a href=\\"#/custom-navbar\\" title=\\"undefined\\">Custom navbar</a></li><li><a href=\\"#/cover\\" title=\\"undefined\\">Cover page</a></li></ul></li><li><p>Customization</p><ul><li><a href=\\"#/configuration\\" title=\\"undefined\\">Configuration</a></li><li><a href=\\"#/themes\\" title=\\"undefined\\">Themes</a></li><li><a href=\\"#/plugins\\" title=\\"undefined\\">List of Plugins</a></li><li><a href=\\"#/write-a-plugin\\" title=\\"undefined\\">Write a Plugin</a></li><li><a href=\\"#/markdown\\" title=\\"undefined\\">Markdown configuration</a></li><li><a href=\\"#/language-highlight\\" title=\\"undefined\\">Language highlighting</a></li><li><a href=\\"#/emoji\\" title=\\"undefined\\">Emoji</a></li></ul></li><li><p>Guide</p><ul><li><a href=\\"#/deploy\\" title=\\"undefined\\">Deploy</a></li><li><a href=\\"#/helpers\\" title=\\"undefined\\">Helpers</a></li><li><a href=\\"#/vue\\" title=\\"undefined\\">Vue compatibility</a></li><li><a href=\\"#/cdn\\" title=\\"undefined\\">CDN</a></li><li><a href=\\"#/pwa\\" title=\\"undefined\\">Offline Mode (PWA)</a></li><li><a href=\\"#/embed-files\\" title=\\"undefined\\">Embed Files</a></li></ul></li><li><p><a href=\\"#/awesome\\" title=\\"undefined\\">Awesome docsify</a></p></li><li><p><a href=\\"#/changelog\\" title=\\"undefined\\">Changelog</a></p></li></ul></div></aside>"`;
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is very difficult to review these sorts of text-based snapshots. The only thing that changed here is that the server-side rendering sidebar menu item has been removed.

@trusktrtrusktr changed the titlefeat: delete SSRdelete SSRJun 25, 2023
@sy-records
Copy link
Member

Use Angular commit message to generate change logs

trusktr reacted with thumbs up emoji

BREAKING: SSR removedAnyone depending on SSR will need to stay on an old Docsify version fornow, move forward without SSR, or maintain SSR against a fork of updatedDocsify. We have ideas on a better way to implement SSR, but these ideashave not been implemented yet.
@trusktr
Copy link
MemberAuthor

Use Angular commit message to generate change logs

Updated

Koooooo-7
Koooooo-7 previously approved these changesJun 26, 2023
@trusktr
Copy link
MemberAuthor

Looks like the codesandbox build sometimes fails when its system limits the number of process (EAGAIN error).

Is there a way to make it retry?

@sy-records
Copy link
Member

I tried to access the admin codesandbox before, but I don't have access.
Previously added by@anikethsaha , Can you help to see it?

trusktr reacted with thumbs up emoji

* develop:  feat: add google analytics gtag.js plugin (#1702)  chore: bump conventional-changelog-cli from 2.2.2 to 3.0.0 (#2085)
@trusktr
Copy link
MemberAuthor

No reply from@anikethsaha yet.

@sy-records@Koooooo-7 codesandbox build is not required, so we can continue anyway.

@trusktr
Copy link
MemberAuthor

@Koooooo-7 Because you already approved, and I merged develop and tests passed but it undid your approval, and then@sy-records approved, I'll go ahead and merge.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sy-recordssy-recordssy-records approved these changes

@Koooooo-7Koooooo-7Awaiting requested review from Koooooo-7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trusktr@sy-records@Koooooo-7

[8]ページ先頭

©2009-2025 Movatter.jp