Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ref #1803: fix cross-origin links in history router mode#1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sy-records merged 1 commit intodevelopfrom1803-history-router-fix-external-links
Jan 22, 2023

Conversation

@trusktr
Copy link
Member

@trusktrtrusktr commentedJan 22, 2023•
edited
Loading

the crossOriginLinks option is no longer needed, remove misspelled "crossorgin" link helper, and instead detect cross origin links and don't handle them as internal

Summary

External links are now navigable by default whenrouterMode ishistory, regardless of theexternalLinksTarget value.

ThecrossOriginLinks option was added as a way to force external links to not be handled as internal.

Instead, that feature has been removed, and now we useisExternal to check for external links, and avoid handling them as internal.

The value of an<a> tag'starget is no longer used as our external link check.

What kind of change does this PR introduce?

Bugfix
Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

ThecrossOriginLinks option is now ignored. I don't think this is breaking. I think people want external links to work properly, so at worst some people will have listed all their links in that array, but now they don't have to.

Thinking of tests to add...

Related issue, if any:

fixes#1803

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE (of course not!)

Koooooo-7 reacted with thumbs up emoji
…sspelled "crossorgin" link helper, and instead detect cross origin links and don't handle them as internal
@vercel
Copy link

vercelbot commentedJan 22, 2023

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated
docsify-preview✅ Ready (Inspect)Visit PreviewJan 22, 2023 at 7:13AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit292e788:

SandboxSource
docsify-templateConfiguration
nostalgic-sea-zouvg0Issue#1803

trusktr added a commit to lume/lume.github.io that referenced this pull requestJan 22, 2023
Copy link
Member

@Koooooo-7Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM !

@sy-recordssy-records merged commitef6905b intodevelopJan 22, 2023
@sy-recordssy-records deleted the 1803-history-router-fix-external-links branchJanuary 22, 2023 17:54
@sy-recordssy-records mentioned this pull requestJun 24, 2023
@sy-recordssy-records mentioned this pull requestMay 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

@sy-recordssy-recordssy-records approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

external links don't work in history router mode

4 participants

@trusktr@Koooooo-7@sy-records
[8]ページ先頭
©2009-2025 Movatter.jp