Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

update: enhance the navigating.#1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Koooooo-7 wants to merge1 commit intodevelop
base:develop
Choose a base branch
Loading
fromenhance-scroll
Draft

Conversation

Koooooo-7
Copy link
Member

Summary

Enhance the navigating stuff on sidebar.
When click the sameanchor, it won't trigger thehashchange event, even though it already scroll down to other part of content.
close#1899

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

FYI, will add the tests later.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercelbot commentedOct 7, 2022

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated
docsify-preview✅ Ready (Inspect)Visit PreviewOct 7, 2022 at 9:11PM (UTC)

@Koooooo-7Koooooo-7 requested a review froma teamOctober 7, 2022 21:12
@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commitb48ca18:

SandboxSource
docsify-templateConfiguration
muddy-sun-fcsrxhIssue#1899

@Koooooo-7Koooooo-7 added the pinnedThis is to pinned the PR/Issue in order to keep it open labelOct 26, 2022
@Koooooo-7
Copy link
MemberAuthor

After more thoughts on it, This PR needs pending for refine the behavior and concern onactive changes actions.
If directly treat all the clink change to triggerhashChangeEvent seems unreasonable.

trusktr reacted with thumbs up emoji

@trusktrtrusktr marked this pull request as draftJanuary 26, 2023 06:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pinnedThis is to pinned the PR/Issue in order to keep it open
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anchor can't be reused twice
1 participant
@Koooooo-7
[8]ページ先頭
©2009-2025 Movatter.jp