Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix the end condition for the embed content handling loop#1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@julienw
Copy link
Contributor

Fixes#1822

Summary

This changes (and effectively fixes) the end condition for the embeds handling loop.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

I didn't see any test related to embed but I'd be happy to update some if needed.

I especially looked at the "embed" page in the documentation, and everything looked good in my opinion.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1822

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercelbot commentedJun 22, 2022•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬Add feedbackMay 18, 2023 6:11am

@codesandbox-ci
Copy link

codesandbox-cibot commentedJun 22, 2022•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit73dc6d6:

SandboxSource
docsify-templateConfiguration
problem-with-docsifyIssue#1822
problem-with-docsifyIssue#1822

julienw added a commit to julienw/perf.html that referenced this pull requestJun 22, 2022
julienw added a commit to julienw/perf.html that referenced this pull requestJun 28, 2022
julienw added a commit to julienw/perf.html that referenced this pull requestJun 28, 2022
julienw added a commit to julienw/perf.html that referenced this pull requestJun 28, 2022
@julienw
Copy link
ContributorAuthor

@sy-records@Koooooo-7 gently ping for this simple patch :-)

@julienw
Copy link
ContributorAuthor

up! thanks for your consideration

@Koooooo-7Koooooo-7 requested a review froma teamJanuary 3, 2023 06:03
@Koooooo-7Koooooo-7 merged commit3fbb9b2 intodocsifyjs:developMay 18, 2023
@sy-recordssy-records mentioned this pull requestMay 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The toc (with subMaxLevel) is generated twice when there's 2 embedded links in a page

2 participants

@julienw@Koooooo-7
[8]ページ先頭
©2009-2025 Movatter.jp