NotificationsYou must be signed in to change notification settings
Fork5.8k
Star30.6k

Fix: Theme preview in Mobile Chrome, Safari#1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

trusktr merged 2 commits intodocsifyjs:developfromiNuanfeng:develop

Dec 10, 2021

Merged

Fix: Theme preview in Mobile Chrome, Safari#1683

trusktr merged 2 commits intodocsifyjs:developfromiNuanfeng:develop

Dec 10, 2021

Conversation

Copy link

Contributor

iNuanfeng commentedDec 6, 2021

Summary

I fix the sidebar style in mobile, when the body height is too small.

before	after

What kind of change does this PR introduce?

Bugfix

For any code change,

Related documentation has been updated if needed
Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

Chrome
Firefox
Safari
Edge
IE

fix sidebar height style in Mobile Chrome

f03eb79

Copy link

vercelbot commentedDec 6, 2021•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/BFAzBQc3zneuuviEnrAiqqYu6EEV
✅ Preview:https://docsify-preview-git-fork-inuanfeng-develop-docsify-core.vercel.app

vercelbotdeployed toPreview

December 6, 2021 02:30

View deployment

Copy link

codesandbox-cibot commentedDec 6, 2021•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit3399977:

Sandbox	Source
docsify-template	Configuration

Copy link

Member

sy-records commentedDec 6, 2021

Can you provide a reproducible environment or repo?

Copy link

Member

Koooooo-7 commentedDec 6, 2021

Concurred with@sy-records .

Copy link

Member

trusktr commentedDec 6, 2021

@sy-records @Koooooo-7 the repo is linked at the top (https://github.com/iNuanfeng/docsify), and the vercel bot provided the live demo.

I tested it (deleted a bunch of elements in devtools inspector) but was not able to reproduce:

But I didn't try on an iPhone. Anyone else with an iPhone?

Copy link

Member

sy-records commentedDec 6, 2021

It's normal for me to use iPhone to view.

Koooooo-7 added the wait for informationsomething is not clear, waiting for the author of the issue/pr label

Dec 6, 2021

Copy link

ContributorAuthor

iNuanfeng commentedDec 7, 2021•
edited
Loading

@sy-records @Koooooo-7 the repo is linked at the top (https://github.com/iNuanfeng/docsify), and the vercel bot provided the live demo.
I tested it (deleted a bunch of elements in devtools inspector) but was not able to reproduce:
But I didn't try on an iPhone. Anyone else with an iPhone?

It will reappear on the iPhone.
My IOS version is 13.4.1
The chrome version on my iPhone is 87.0.4280.163

Copy link

ContributorAuthor

iNuanfeng commentedDec 7, 2021•
edited
Loading

@sy-records When the content of the document is too small, it will be reproduced

Copy link

ContributorAuthor

iNuanfeng commentedDec 7, 2021 via email

你好，我的MR（#1683）中，指的是文档内容过少，没有撑满一屏长度的时候，左侧侧边栏会无法显示全。环境是iphone下的chrome

…

------------------ 原始邮件 ------------------发件人: ***@***.***>;发送时间: 2021年12月6日(星期一) 下午5:26收件人: ***@***.***>;抄送: ***@***.***>; ***@***.***>;主题: Re: [docsifyjs/docsify] Fix: Theme preview in Mobile Chrome, Safari (PR#1683)It's normal for me to use iPhone to view.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

Copy link

Member

sy-records commentedDec 7, 2021

I don't have that version of the device.

I am using IOS15 and Chrome 97 is working fine.

https://github.com/iNuanfeng/iNuanfeng.github.io

Copy link

Member

trusktr commentedDec 7, 2021

@sy-records did you try with a small amount of content? Your screen shows a lot of content beyond the end of the bottom of the screen. See our screenshots that have little content.