Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Use legacy-compatible methods for IE11#1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jhildenbiddle merged 2 commits intodevelopfromfix-search-ie11
Feb 7, 2021

Conversation

@jhildenbiddle
Copy link
Member

Summary

Modern convenience methods likeArray.prototype.find() andString.prototype.startsWith() are not compatible with legacy browsers like IE11. This PR replaces those methods with legacy-compatible approaches that accomplish the same thing.

What kind of change does this PR introduce? (check at least one)

  • Bugfix

If changing the UI of default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercelbot commentedFeb 7, 2021•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/67c5ixoo8
✅ Preview:https://docsify-preview-git-fix-search-ie11.docsify-core.vercel.app

@jhildenbiddlejhildenbiddle requested a review froma teamFebruary 7, 2021 06:52
@codesandbox-ci
Copy link

codesandbox-cibot commentedFeb 7, 2021•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit37b7166:

SandboxSource
docsify-templateConfiguration

@sy-recordssy-records mentioned this pull requestFeb 7, 2021
3 tasks
Copy link
Member

@sy-recordssy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for your contribution!

Copy link
Member

@Koooooo-7Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sy-recordssy-recordssy-records approved these changes

@anikethsahaanikethsahaAwaiting requested review from anikethsaha

@Koooooo-7Koooooo-7Awaiting requested review from Koooooo-7

@trusktrtrusktrAwaiting requested review from trusktr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhildenbiddle@Koooooo-7@sy-records
[8]ページ先頭
©2009-2025 Movatter.jp