Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: sidebar active class and expand don't work as expect when use "space" in markdown filename#1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sy-records merged 3 commits intodocsifyjs:developfromenzy:fix/1032
Dec 20, 2020

Conversation

@enzy
Copy link
Contributor

@enzyenzy commentedDec 17, 2020
edited by sy-records
Loading

Summary

This PR fixes URL decoding problem in sidebar, reported in#1032. It builds on previous work in#1043, but with rebased and updated fix (just 1 line now).

What kind of change does this PR introduce? (check at least one)

  • Bugfix

If changing the UI of default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding anew feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.

@vercel
Copy link

vercelbot commentedDec 17, 2020
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/lmdo37xnk
✅ Preview:https://docsify-preview-git-fix-1032.docsify-core.now.sh

@codesandbox-ci
Copy link

codesandbox-cibot commentedDec 17, 2020
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit92c6810:

SandboxSource
docsify-templateConfiguration

trusktr
trusktr previously approved these changesDec 17, 2020
@trusktr
Copy link
Member

Thanks for this! I think this looks good.

@sy-records
Copy link
Member

sy-records commentedDec 17, 2020
edited
Loading

Can you add a test? I added

enzy reacted with thumbs up emoji

@sy-recordssy-records changed the titleFix href decode in sidebar (#1032)fix: href decode in sidebarDec 18, 2020
@sy-recordssy-records changed the titlefix: href decode in sidebarfix: sidebar active class and expand don't work as expect when use "space" in markdown filenameDec 18, 2020
@sy-recordssy-records merged commitdcf5a64 intodocsifyjs:developDec 20, 2020

await page.click('a[href="#/test"]');
await expect(page).toEqualText('.sidebar-nav li[class=active]', 'Test');
expect(page.url()).toMatch(/\/test$/);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! I get a good warm feeling of Docsify stability improving now!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@trusktrtrusktrtrusktr left review comments

@Koooooo-7Koooooo-7Koooooo-7 approved these changes

@sy-recordssy-recordssy-records approved these changes

@anikethsahaanikethsahaAwaiting requested review from anikethsaha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sidebar active class and expand don't work as expect when use "space" in markdown filename

4 participants

@enzy@trusktr@sy-records@Koooooo-7

[8]ページ先頭

©2009-2025 Movatter.jp