Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

trusktr testing (IGNORE THIS)#1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
trusktr wants to merge1 commit intodevelop
base:develop
Choose a base branch
Loading
fromtrusktr-testing
Draft

Conversation

@trusktr
Copy link
Member

@trusktrtrusktr commentedNov 1, 2020•
edited
Loading

Just a PR I'm using for running tests.

… need to test marked either, as we assume that the marked library works as advertised in whichever way they tested it.
@vercel
Copy link

vercelbot commentedNov 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/b949nbmh9
✅ Preview:https://docsify-preview-git-trusktr-testing.docsify-core.vercel.app

@trusktrtrusktr changed the titleWe don't need to init if we're only testing marked. We probably don't…trusktr testingNov 1, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit9847f69:

SandboxSource
docsify-templateConfiguration

@jhildenbiddle
Copy link
Member

@trusktr FWIW, I don't think we need to testmarked either. I only converted these tests from the old setup because I didn't want anyone to say "what happened to test X". I figured discussions about what tests we can get rid of could happen after the conversion.

@trusktrtrusktr marked this pull request as draftNovember 1, 2020 23:15
@trusktr
Copy link
MemberAuthor

Cool. Just testing anyway. The test didn't pass because importing marked directly does not include our custom additions.

jhildenbiddle reacted with thumbs up emoji

@trusktrtrusktr changed the titletrusktr testingtrusktr testing (IGNORE THIS)Nov 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trusktr@jhildenbiddle
[8]ページ先頭
©2009-2025 Movatter.jp