Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
fix: duplicate search content when/README or/ exists in the sidebar#1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedOct 20, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/3x18lja8p |
codesandbox-cibot commentedOct 20, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commitd6800c3:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tested this PR locally and still encounter the issue. To reproduce the error:
- Add the following line to
_sidebar.md:- [README](README) - Launch test server with the following CLI command:
node ./test/config/server.js --start
- Search for "generator"
Results
We should also add tests for this scenario (no duplicates).
Uh oh!
There was an error while loading.Please reload this page.
You need to run
|
@sy-records -- Fixed the test. Required updating the Playwright config to clear local storage before each test. I assumed that would have been done before, but apparently not. See the following branch:https://github.com/docsifyjs/docsify/tree/pullrequests/sy-records/fix-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Summary
fix: duplicate search content when
/READMEor/exists in the sidebar.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide thebefore/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding anew feature, the PR's description includes:
To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.