NotificationsYou must be signed in to change notification settings
Fork5.8k
Star30.6k

fix: Can't search homepage content#1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sy-records merged 4 commits intodocsifyjs:developfromsy-records:fix-search

Oct 14, 2020

Merged

fix: Can't search homepage content#1391

sy-records merged 4 commits intodocsifyjs:developfromsy-records:fix-search

Oct 14, 2020

Conversation

Copy link

Member

sy-records commentedOct 12, 2020

Summary

fix#1080

What kind of change does this PR introduce? (check at least one)

Bugfix
Feature
Code style update
Refactor
Docs
Build-related changes
Repo settings
Other, please describe:

If changing the UI of default theme, please provide thebefore/after screenshot:

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

Chrome
Firefox
Safari
Edge
IE

If adding anew feature, the PR's description includes:

A convincing reason for adding this feature
Related documents have been updated
Related tests have been updated

To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.

fix: Can't search homepage content

10b3a4e

Copy link

vercelbot commentedOct 12, 2020•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/gcnf2rmjl
✅ Preview:https://docsify-preview-git-fix-search.docsify-core.vercel.app

vercelbotdeployed toPreview

October 12, 2020 08:11

View deployment

sy-records requested review fromKoooooo-7,anikethsaha,jhildenbiddle andtrusktr

October 12, 2020 08:13

Copy link

codesandbox-cibot commentedOct 12, 2020•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commita7a81d7:

Sandbox	Source
docsify-template	Configuration

fix: when pathNamespaces does not exist

f998ff2

vercelbotdeployed toPreview

October 12, 2020 08:20

View deployment

Copy link

Member

Koooooo-7 commentedOct 13, 2020

I hvnt understood where the issue/bug is yet. 😅
Could u do me a flavor that showing some pics or reproduce steps.

Copy link

MemberAuthor

sy-records commentedOct 13, 2020

For example,site generator cannot be searched

It is in the readme.

add test

29e3454

vercelbotdeployed toPreview

October 14, 2020 02:01

View deployment

update test to fix windows ci

a7a81d7

vercelbotdeployed toPreview

October 14, 2020 02:44

View deployment

Koooooo-7 approved these changes

Oct 14, 2020

View reviewed changes

anikethsaha approved these changes

Oct 14, 2020

View reviewed changes

Copy link

Member

anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

THANKS

sy-records merged commit25bc9b7 intodocsifyjs:develop

Oct 14, 2020

sy-records deleted the fix-search branch

October 14, 2020 04:40

Koooooo-7 pushed a commit to Koooooo-7/docsify that referenced this pull request

Oct 15, 2020

fix: Can't search homepage content (docsifyjs#1391)

9bfac00

* fix: Can't search homepage content* fix: when pathNamespaces does not exist* add test* update test to fix windows ci

trusktr added a commit that referenced this pull request

Nov 2, 2020

Merge branch 'develop' into fix-validating-remote-content

d516198

* develop: (81 commits)  fix: upgrade dompurify from 2.1.0 to 2.1.1 (#1402)  fix: upgrade dompurify from 2.0.17 to 2.1.0 (#1397)  fix: search on homepage test (#1398)  fix: the sidebar links to another site. (#1336)  fix: Can't search homepage content (#1391)  fix: upgrade debug from 4.1.1 to 4.3.0 (#1390)  fix: packages/docsify-server-renderer/package.json & packages/docsify-server-renderer/package-lock.json to reduce vulnerabilities (#1389)  Fix eslint warnings (#1388)  docs: add crossOriginLinks configurations details. (#1386)  Remove Cypress screenshots  Fix friendly message display  Add Vue 3 compatibility  Show dir listing & help msg for manual instance  Add NODE_MODULES_URL global  Jest + Playwright Testing (#1276)  update doc (#1381)  Fix scroll event end value  fix: upgrade docsify from 4.11.4 to 4.11.6 (#1373)  chore(deps): bump node-fetch in /packages/docsify-server-renderer (#1370)  test: fix cannot search list content (#1367)  ...