Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
Fix git commit typo#1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix git commit typo#1347
Conversation
vercelbot commentedAug 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/heptqao5t |
codesandbox-cibot commentedAug 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit5041399:
|
Koooooo-7 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, I dont think there is a typo.
When you use thegit commit -am, it will include thegit add <changed files> command in it.
Maybe you can change it togit add . && git commit -m in case of leaving some new files out which have not been tracked.
@Koooooo-7 I agree with you. I just included only the -m tag for message but didn't notice the add tag. So, yeah. I'll change in the code and say! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
| - Fork it! | ||
| - Create your feature branch:`git checkout -b my-new-feature` | ||
| - Commit your changes:`git commit -am 'Add some feature'` | ||
| - Commit your changes:`gitadd . && gitcommit -m 'Add some feature'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's the same thing, but I always use git add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is the same thing, but I didn't use this -am flag all time. So yeah!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Basically, it is just a litte different thatgit commit -am wont commit those untracked files(the new files you create).
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide thebefore/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding anew feature, the PR's description includes:
To avoid wasting your time, it's best to open afeature request issue first and wait for approval before working on it.