Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitdcf5a64

Browse files
enzysy-records
andauthored
fix: sidebar active class and expand don't work as expect when use "space" in markdown filename (#1454)
* fix: decode href in sidebar (#1032)* Create sidebar.test.jsCo-authored-by: 沈唁 <52o@qq52o.cn>
1 parent76c5e68 commitdcf5a64

File tree

2 files changed

+71
-1
lines changed

2 files changed

+71
-1
lines changed

‎src/core/event/sidebar.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export function getAndActive(router, el, isParent, autoTitle) {
8383
links
8484
.sort((a,b)=>b.href.length-a.href.length)
8585
.forEach(a=>{
86-
consthref=a.getAttribute('href');
86+
consthref=decodeURI(a.getAttribute('href'));
8787
constnode=isParent ?a.parentNode :a;
8888

8989
a.title=a.title||a.innerText;

‎test/e2e/sidebar.test.js‎

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
constdocsifyInit=require('../helpers/docsify-init');
2+
3+
// Suite
4+
// -----------------------------------------------------------------------------
5+
describe('Sidebar Tests',function(){
6+
// Tests
7+
// ---------------------------------------------------------------------------
8+
test('Active Test',async()=>{
9+
constdocsifyInitConfig={
10+
markdown:{
11+
sidebar:`
12+
- [Test Space](test%20space)
13+
- [Test _](test_foo)
14+
- [Test -](test-foo)
15+
- [Test .](test.foo)
16+
- [Test >](test>foo)
17+
- [Test](test)
18+
`,
19+
},
20+
routes:{
21+
'/test space.md':`
22+
# Test Space
23+
`,
24+
'/test_foo.md':`
25+
# Test _
26+
`,
27+
'/test-foo.md':`
28+
# Test -
29+
`,
30+
'/test.foo.md':`
31+
# Test .
32+
`,
33+
'/test>foo.md':`
34+
# Test >
35+
`,
36+
'/test.md':`
37+
# Test page
38+
`,
39+
},
40+
};
41+
42+
awaitdocsifyInit(docsifyInitConfig);
43+
awaitpage.click('a[href="#/test%20space"]');
44+
awaitexpect(page).toEqualText(
45+
'.sidebar-nav li[class=active]',
46+
'Test Space'
47+
);
48+
expect(page.url()).toMatch(/\/test%20space$/);
49+
50+
awaitpage.click('a[href="#/test_foo"]');
51+
awaitexpect(page).toEqualText('.sidebar-nav li[class=active]','Test _');
52+
expect(page.url()).toMatch(/\/test_foo$/);
53+
54+
awaitpage.click('a[href="#/test-foo"]');
55+
awaitexpect(page).toEqualText('.sidebar-nav li[class=active]','Test -');
56+
expect(page.url()).toMatch(/\/test-foo$/);
57+
58+
awaitpage.click('a[href="#/test.foo"]');
59+
awaitexpect(page).toEqualText('.sidebar-nav li[class=active]','Test .');
60+
expect(page.url()).toMatch(/\/test.foo$/);
61+
62+
awaitpage.click('a[href="#/test>foo"]');
63+
awaitexpect(page).toEqualText('.sidebar-nav li[class=active]','Test >');
64+
expect(page.url()).toMatch(/\/test%3Efoo$/);
65+
66+
awaitpage.click('a[href="#/test"]');
67+
awaitexpect(page).toEqualText('.sidebar-nav li[class=active]','Test');
68+
expect(page.url()).toMatch(/\/test$/);
69+
});
70+
});

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp