- Notifications
You must be signed in to change notification settings - Fork146
Improve docopt-config.cmake in case of Boost regex#140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Improve docopt-config.cmake in case of Boost regex#140
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This commit declares the transitive dependency to Boost in case docoptis build with Boost regex support. In this way, the user doesn't needto declare the dependency to Boost manually.
jaredgrubb commentedMar 25, 2022
I'm not a make expert so it'd be nice to get some other eyes on this that can confirm this approach is reasonable. |
eaaltonen left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I tested this on a local project with docopt built with option-DUSE_BOOST_REGEX=True. Dependency works as expected and the CMake followsCMake packaging instructions AFAICT.
This commit declares the transitive dependency to Boost in case docopt is build with Boost regex support. In this way, the user doesn't need to declare the dependency to Boost manually.