NotificationsYou must be signed in to change notification settings
Fork1.2k
Star2.3k

Do not try to create databases that already exist#801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

yosifkit merged 1 commit intodocker-library:masterfrominfosiftr:db-exists

Dec 28, 2020

Merged

Do not try to create databases that already exist#801

yosifkit merged 1 commit intodocker-library:masterfrominfosiftr:db-exists

Dec 28, 2020

Conversation

Copy link

Member

tianon commentedDec 21, 2020

We were already checking for whetherPOSTGRES_DB was set topostgres, but this was the underlying motivation for that check (and it turns out that this applies for values of at leasttemplate0 andtemplate1 as well).

Closes#794

(Just to keep the thread,https://stackoverflow.com/a/18389184/433558 still makes me depressed 😅 -#794 (comment))

Do not try to create databases that already exist

11e397d

We were already checking for whether `POSTGRES_DB` was set to `postgres`, but this was the underlying motivation for that check (and it turns out that this applies for values of at least `template0` and `template1` as well).

tianon force-pushed thedb-exists branch fromf8bada6 to11e397dCompare

December 22, 2020 22:00

yosifkit approved these changes

Dec 28, 2020

View reviewed changes

yosifkit merged commit03e7695 intodocker-library:master

Dec 28, 2020

yosifkit deleted the db-exists branch

December 28, 2020 22:39

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request

Dec 29, 2020

Update postgres

2414074

Changes:-docker-library/postgres@03e7695: Merge pull requestdocker-library/postgres#801 from infosiftr/db-exists-docker-library/postgres@eaeb73d: Merge pull requestdocker-library/postgres#804 from infosiftr/chmod-no-fail-docker-library/postgres@36ffea2: Adjust "chmod" to not fail (since PostgreSQL validates this itself later)-docker-library/postgres@11e397d: Do not try to create databases that already exist-docker-library/postgres@3690694: Merge pull requestdocker-library/postgres#797 from infosiftr/rc-beta-alpha-docker-library/postgres@dba8ec0: Adjust tagging to enforce explicit pre-release opt-in