- Notifications
You must be signed in to change notification settings - Fork1.2k
12 changed into {{ env.version }}#1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The reason this is tagged to a specific version is because theserver-start.html page might go away or move elsewhere in the future -- it's not guaranteed to exist forevery version we support, and we certainly don't want to maintain a conditional herejust to make the URL point to a page that exists for the given version we're generating.
It's similar in spirit to linking to a markdown file on a GitHub branch vs a "permalink" to a commit.
So, if there's a newer version of this page we can link to, I'm happy to accept that change, but updating it to something that automatically (blindly) updates the URL is a no-go for me. 😇 ❤️
|
This pull request updates the PostgreSQL Dockerfile by replacing hardcoded version numbers (12) with the environment variable {{ env.version }}. I believe that updating the documentation links is a good idea as PostgreSQL version 12 is approaching its end of support.