Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: adding opensearch integration#1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jay-bhambhani wants to merge3 commits intodocarray:main
base:main
Choose a base branch
Loading
fromjay-bhambhani:feat_opensearch_integration

Conversation

@jay-bhambhani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecovbot commentedFeb 21, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is27.97428% with224 lines in your changes missing coverage. Please review.

Project coverage is 63.15%. Comparing base(82d7cee) to head(f9d56be).
Report is 11 commits behind head on main.

Files with missing linesPatch %Lines
docarray/index/backends/opensearchv2.py27.36%223 Missing⚠️
docarray/index/__init__.py75.00%1 Missing⚠️
Additional details and impacted files
@@             Coverage Diff             @@##             main    #1915       +/-   ##===========================================+ Coverage   29.01%   63.15%   +34.14%===========================================  Files         136      137        +1       Lines        9468     9782      +314     ===========================================+ Hits         2747     6178     +3431+ Misses       6721     3604     -3117
FlagCoverage Δ
docarray63.15% <27.97%> (+34.14%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@jay-bhambhani
Copy link
ContributorAuthor

#1917

@JoanFM
Copy link
Member

Hello@jay-bhambhani ,

Thanks for this contribution.

I would need you to sign the DCO for this to be accepted. Can you check our guidelines.

@jay-bhambhanijay-bhambhaniforce-pushed thefeat_opensearch_integration branch fromed98b77 to914d648CompareMarch 1, 2025 00:37
@jay-bhambhani
Copy link
ContributorAuthor

thanks@JoanFM ! sorry i was still in the process of getting tests to pass - i 'm almost done cleaning up and this should be good for real review!

rename files and make some other fixesmissed the pytest markspytest markerone more spot?testundo docker for local testingfixes and cleanupSigned-off-by: Jay Bhambhani <jaybhambhani@pop-os.localdomain>fixup pyproject.tomlSigned-off-by: Jay Bhambhani <jaybhambhani@pop-os.localdomain>
@jay-bhambhanijay-bhambhaniforce-pushed thefeat_opensearch_integration branch from914d648 to4124812CompareMarch 1, 2025 00:41
@jay-bhambhani
Copy link
ContributorAuthor

hi@JoanFM! if i run poetry update it tends to hang. is there a fix for this?

@jay-bhambhani
Copy link
ContributorAuthor

@JoanFM can i please ask for some help with this?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoanFMJoanFMAwaiting requested review from JoanFM

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jay-bhambhani@JoanFM
[8]ページ先頭
©2009-2025 Movatter.jp