Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: pad audio arrays to same shape if sample rates differ#1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chrisammon3000 wants to merge3 commits intodocarray:main
base:main
Choose a base branch
Loading
fromchrisammon3000:fix-audio-tensor-mismatch

Conversation

chrisammon3000
Copy link

@chrisammon3000chrisammon3000 commentedApr 3, 2024•
edited
Loading

Description

Please refer to#1875 for a detailed description of the issue this fixes. When ffmpeg creates subclips of a video sometimes the audio sample rates are inconsistent causing an error due to different size arrays. To fix this the arrays are padded to ensure they are all the same shape before they are parsed as AudioNdArray.

Copy link
Member

@JoanFMJoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It would be nice to add a test case to show that the problem is fixed.

@JoanFM
Copy link
Member

Hey@chrisammon3000 ,

Thanks a lot for the contribution.

However we would ask you to submit a test case to make sure the error case is covered and to make sure that the commits aresigned-off to ensure that we can merge the contribution.

Please take a look at our contributing guidelines (https://github.com/docarray/docarray/blob/main/CONTRIBUTING.md)

@codecovCodecov
Copy link

codecovbot commentedApr 4, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is36.36364% with7 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base(febbdc4) to head(a574002).
Report is 1 commits behind head on main.

❗Current heada574002 differs from pull request most recent head5f3141c

Pleaseupload reports for the commit5f3141c to get more accurate results.

FilesPatch %Lines
docarray/typing/bytes/video_bytes.py36.36%7 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #1880      +/-   ##==========================================- Coverage   84.69%   84.63%   -0.06%==========================================  Files         136      136                Lines        9263     9274      +11     ==========================================+ Hits         7845     7849       +4- Misses       1418     1425       +7
FlagCoverage Δ
docarray84.63% <36.36%> (-0.06%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoanFMJoanFMJoanFM requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@chrisammon3000@JoanFM
[8]ページ先頭
©2009-2025 Movatter.jp