- Notifications
You must be signed in to change notification settings - Fork302
Add relationships support for pointers in errors#986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@sliverc This is my draft attempt at solving the problem. I was wondering if you could give me some hints on whether I'm headed in the right direction or not? |
codecovbot commentedOct 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #986 +/- ##==========================================+ Coverage 96.83% 96.84% +0.01%========================================== Files 65 65 Lines 3914 3929 +15 ==========================================+ Hits 3790 3805 +15 Misses 124 124
Continue to review full report at Codecov.
|
Yes you are on the right track. |
@sliverc Great! Thanks! |
@sliverc |
@sliverc I couldn't understand why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for working on this. Please see my inline comments.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@sliverc Resolved all the issues you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is shaping up nicely. See some small comments inline.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@sliverc Done as well. Thanks for the tips. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the changes. Somewhat one of my comment got swallowed (maybe had to many tabs open... 😄 ) See last comment, also rebase to current master and then this PR is good to merge.
Uh oh!
There was an error while loading.Please reload this page.
and totally forgot please also add a changelog entry. |
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
@sliverc I think we're good to go :D |
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the changes and your time putting into making this work. Very appreciated.
It seems that you (your IDE?) autoformatted the changelog markdown file (I guess with prettier?). There were quite a few changes... I reverted those to make this PR ready. But certainly something to think about whether as DJA we want to autoformat md files but I guess part of another discussion.
Thanks again.
@sliverc You're very welcome! |
Uh oh!
There was an error while loading.Please reload this page.
Fixes#413
Description of the Change
When formatting DRF errors, use
relationships
in the pointer when the field is actually a relationship.Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS