- Notifications
You must be signed in to change notification settings - Fork302
Remove invalid validation of default included_resources#956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove invalid validation of default included_resources#956
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedJul 6, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #956 +/- ##======================================= Coverage 96.81% 96.81% ======================================= Files 64 64 Lines 3888 3888 ======================================= Hits 3764 3764 Misses 124 124
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Fixes#949
Description of the Change
#900 inadvertently introduced validation of default included_resources which does not work properly with nested included resources (such as when a default included resources also defines its own included resources).
This PR reverts this validation but leaving the default prefetching of default included resources as intended in PR#900.
This is a quick fix to get this regression solved. In the long run we need to think whether it makes sense at all to do validation of include in init of the serializer anyway. But can be discussed later.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS