Avoided error when using include query parameter on related urls#914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

n2ygk merged 2 commits intodjango-json-api:masterfromsliverc:include_related_field

Apr 23, 2021

Merged

Avoided error when using include query parameter on related urls#914

n2ygk merged 2 commits intodjango-json-api:masterfromsliverc:include_related_field

Apr 23, 2021

Conversation

Copy link

Member

sliverc commentedApr 16, 2021

Description of the Change

Usinginclude on related urls always through an error even when correctly configured.
This is a regression of version 4.1.0.

Checklist

PR only contains one change (considered splitting up PR)
unit-test added
documentation updated
CHANGELOG.md updated (only for user relevant changes)
author name inAUTHORS

Avoided error when using include query parameter on related urls

955b28c

This is a regression from version 4.1.0.

sliverc requested a review fromn2ygk

April 16, 2021 13:36

Copy link

codecovbot commentedApr 16, 2021•
edited
Loading

Codecov Report

Merging#914 (a76396b) intomaster (36a60a3) willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master     #914   +/-   ##=======================================  Coverage   97.67%   97.67%           =======================================  Files          58       58             Lines        3093     3102    +9     =======================================+ Hits         3021     3030    +9  Misses         72       72

Impacted Files	Coverage Δ
example/tests/integration/test_browsable_api.py	`100.00% <100.00%> (ø)`
rest_framework_json_api/renderers.py	`90.15% <100.00%> (+0.06%)`	⬆️
tests/test_views.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update36a60a3...a76396b. Read thecomment docs.