Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

JSONAPI prefix for paginators#463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sliverc merged 2 commits intodjango-json-api:masterfromn2ygk:std-JSONAPI-prefix
Aug 22, 2018

Conversation

n2ygk
Copy link
Contributor

Description of the Change

Per adiscussion with@sliverc, renamed recently-added pagination classes fromJsonApi-prefix toJSONAPI-prefix. This includes new deprecation warnings for the old names.

I also added a minor fix to tox.ini not to run flake8 on the entire directory but only the relevant files.
You can cherry-pick that out if you prefer it not to be part of this PR.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added (no change; just class renamed)
  • documentation updated
  • changelog entry added toCHANGELOG.md
  • author name inAUTHORS

(This replaces#458 where I messed up the history by rebasing incorrectly.)

@n2ygkn2ygk requested a review fromslivercAugust 21, 2018 21:14
@codecov-io
Copy link

codecov-io commentedAug 21, 2018
edited
Loading

Codecov Report

Merging#463 intomaster willincrease coverage by0.03%.
The diff coverage is96.29%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #463      +/-   ##==========================================+ Coverage   93.33%   93.37%   +0.03%==========================================  Files          56       56                Lines        3164     3183      +19     ==========================================+ Hits         2953     2972      +19  Misses        211      211
Impacted FilesCoverage Δ
rest_framework_json_api/pagination.py95.31% <100%> (+0.97%)⬆️
example/tests/unit/test_pagination.py100% <100%> (ø)⬆️
example/views.py91.89% <66.66%> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update81d2236...f04f95e. Read thecomment docs.

Copy link
Member

@slivercsliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks.

@slivercsliverc merged commite6290af intodjango-json-api:masterAug 22, 2018
@n2ygkn2ygk deleted the std-JSONAPI-prefix branchAugust 22, 2018 13:25
@n2ygkn2ygk mentioned this pull requestAug 30, 2018
n2ygk added a commit to n2ygk/django-rest-framework-json-api that referenced this pull requestAug 30, 2018
@n2ygkn2ygk mentioned this pull requestAug 31, 2018
5 tasks
@n2ygkn2ygk added this to the2.6.0 milestoneSep 18, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slivercslivercsliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@n2ygk@codecov-io@sliverc

[8]ページ先頭

©2009-2025 Movatter.jp