Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Removed built-in OpenAPI support#1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sliverc wants to merge2 commits intodjango-json-api:main
base:main
Choose a base branch
Loading
fromsliverc:remove_openapi

Conversation

sliverc
Copy link
Member

@slivercsliverc commentedJul 18, 2025
edited
Loading

Description of the Change

Planning a new major release 8.0.0 I thought it is time to also remove built-in OpenAPI support as it has been deprecated for quite a while now and it also does not work with the newestdjango-filter version anymore.

In case there are any concerns removing it please let me know.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name inAUTHORS

@slivercsliverc requested a review fromn2ygkJuly 18, 2025 13:20
@sliverc
Copy link
MemberAuthor

@n2ygk Just saw that I missed removing some code, pushed that now. In case you consider this for merging, could you also test in an actual project that schema generation still works with drf-spectacular-json-api and these changes?
I do not have an actual project, so won't be able to check on that.

n2ygk reacted with thumbs up emoji

@n2ygk
Copy link
Contributor

@n2ygk Just saw that I missed removing some code, pushed that now. In case you consider this for merging, could you also test in an actual project that schema generation still works with drf-spectacular-json-api and these changes? I do not have an actual project, so won't be able to check on that.

Looks like the main branch already breaks my demo app. It's going to take me a while to debug that. Probably breaking changes to setuptools that I have to resolve first...

Here's a snippet:

openapi: recreate env because requirements removed: djangorestframework-jsonapi==7.1.0openapi: remove tox env folder /Users/ac45/src/django-jsonapi-training/.tox/openapiopenapi: install_deps> python -I -m pip install -r requirements.txt.pkg: _optional_hooks> python /Users/ac45/src/django-jsonapi-training/venv/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__.pkg: get_requires_for_build_sdist> python /Users/ac45/src/django-jsonapi-training/venv/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__openapi: packaging backend failed (code=error in myapp setup command: 'install_requires' must be a string or iterable of strings containing valid project/version requirement specifiers; Expected package name at the start of dependency specifier    /Users/ac45/src/django-rest-framework-json-api    ^), with SystemExit: error in myapp setup command: 'install_requires' must be a string or iterable of strings containing valid project/version requirement specifiers; Expected package name at the start of dependency specifier    /Users/ac45/src/django-rest-framework-json-api    ^Traceback (most recent call last):  File "/Users/ac45/src/django-jsonapi-training/.tox/.pkg/lib/python3.12/site-packages/setuptools/_vendor/packaging/requirements.py", line 36, in __init__    parsed = _parse_requirement(requirement_string)             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/Users/ac45/src/django-jsonapi-training/.tox/.pkg/lib/python3.12/site-packages/setuptools/_vendor/packaging/_parser.py", line 62, in parse_requirement    return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES))           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/Users/ac45/src/django-jsonapi-training/.tox/.pkg/lib/python3.12/site-packages/setuptools/_vendor/packaging/_parser.py", line 71, in _parse_requirement    name_token = tokenizer.expect(                 ^^^^^^^^^^^^^^^^^  File "/Users/ac45/src/django-jsonapi-training/.tox/.pkg/lib/python3.12/site-packages/setuptools/_vendor/packaging/_tokenizer.py", line 142, in expect    raise self.raise_syntax_error(f"Expected {expected}")          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/Users/ac45/src/django-jsonapi-training/.tox/.pkg/lib/python3.12/site-packages/setuptools/_vendor/packaging/_tokenizer.py", line 167, in raise_syntax_error    raise ParserSyntaxError(packaging._tokenizer.ParserSyntaxError: Expected package name at the start of dependency specifier    /Users/ac45/src/django-rest-framework-json-api

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@n2ygkn2ygkAwaiting requested review from n2ygk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sliverc@n2ygk

[8]ページ先頭

©2009-2025 Movatter.jp