- Notifications
You must be signed in to change notification settings - Fork302
Remove transitive dependency sqlparse from example/requirements.txt#1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for the hinter. Actually, the example/requirements.txt file is obsolete and is not referenced anywhere or used at this point. Therefore, example/requirements.txt can be completely removed, as the requirements.txt in the root folder is the correct one and referenced in the README, |
Super seeded by#1287 therefore closing. Thanks for your initial hinter. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#1284
Description of the Change
As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.
Specifically, the transitive dependency
sqlparse, which is required by Django, is specified as a requirement in theexample/requirements.txtfile, even though it is not used directly and does not need to be listed explicitly.This PR removes it from
example/requirements.txtto let pip manage it automatically, which helps keeping the dependency list clean.Hope this is helpful!
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS