django-json-api/django-rest-framework-json-apiPublic

NotificationsYou must be signed in to change notification settings
Fork302
Star1.2k

Removed support for Python 3.8#1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sliverc merged 3 commits intodjango-json-api:mainfromn2ygk:deprecate_3.8

Jan 13, 2025

Merged

Removed support for Python 3.8#1266

sliverc merged 3 commits intodjango-json-api:mainfromn2ygk:deprecate_3.8

Jan 13, 2025

Conversation

Copy link

Contributor

Description of the Change

Remove Python 3.8 which is EOL perPEP 569

Checklist

PR only contains one change (considered splitting up PR)
unit-test added
documentation updated
CHANGELOG.md updated (only for user relevant changes)
author name inAUTHORS

n2ygk added2 commits

January 7, 2025 11:35

Python 3.8 EoL per PEP569

abd4177

changelog

abe9573

n2ygk requested a review fromsliverc

January 7, 2025 16:38

Copy link

ContributorAuthor

n2ygk commentedJan 7, 2025

drfmaster tests are throwing an error for TypeError for encode of None. Maybe related to#1229?

Copy link

Member

sliverc commentedJan 7, 2025

There is an upstream change in DRF which caused these errors. I have submitted a PR hereencode/django-rest-framework#9615 hope it will be merged soon.

sliverc requested changes

Jan 7, 2025

View reviewed changes

Copy link

Member

sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this. getting-started.md needs also to be adjusted I think and also add a note in changelog to version 7.1.0 that states that it is the last version supporting 3.7. See how we did it in#1178

changes per@slivercreview

e5327c0

Copy link

ContributorAuthor

n2ygk commentedJan 9, 2025

@sliverc

Thanks for working on this. getting-started.md needs also to be adjusted I think and also add a note in changelog to version 7.1.0 that states that it is the last version supporting 3.7. See how we did it in#1178

Done.

Also, perhaps as a separate PR, should we make a failed drfmaster test a non-fatal workflow error? That's how we do it in DOT, for example:https://github.com/jazzband/django-oauth-toolkit/blob/master/tox.ini#L57-L59. Right now, errors in non-released DRF are blocking successful PRs here.