- Notifications
You must be signed in to change notification settings - Fork302
Added support for 3.13#1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8596f7e to8107ab1CompareThis will only be supported on Django 5.1 and above.seehttps://forum.djangoproject.com/t/backport-python-3-13-support-in-django-5-0/34671
so only master till it is released.seehttps://github.com/encode/django-rest-framework/pull/9527/files
n2ygk approved these changesOct 8, 2024
c686ded intodjango-json-api:main 12 checks passed
Uh oh!
There was an error while loading.Please reload this page.
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description of the Change
Python 3.13 will only be supported byDjango 5.1 and above.
Currently, 3.13 has not been released yet onGithub so using Python 3.13-dev. This should be removed once it is released.
Additionally, DRF made achange to how description is retrieved. Tests with DRF 3.15 are failing because of that, so only testing on drfmaster. However, as schema support is deprecated anyway, I suppose we can still mark DJA to support Python 3.13 before DRF releases another version.
As only drfmaster is tested for Python 3.13 it does not make sense to ignore it. As of the issue we had in#1251 I removed all ignores, so we get notified if something goes wrong.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS