Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add HTTP 429 Too Many Requests as a possible generic error response#1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

js-nh
Copy link
Contributor

@js-nhjs-nh commentedMay 20, 2024•
edited
Loading

Fixes #

Description of the Change

Adds429 Too Many Requests as a possible generic error response.

Discovered during an OpenAPI schema validation run as our generic error responses were not found in the schema.

This is essentially same as#1165 but for429 status code.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name inAUTHORS

@js-nhjs-nhforce-pushed theopenapi-429-too-many-requests branch fromf71e0df to0a27fa9CompareMay 21, 2024 08:42
@js-nh
Copy link
ContributorAuthor

There was a typo - I had a trailing, in the json structure. It should be resolved now, tests are passing locally.

@js-nh
Copy link
ContributorAuthor

@sliverc Could I ask you to review this and tell me how I could proceed with getting this merged, if possible?

Copy link
Member

@slivercsliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the addition. This looks good to me and ready to merge.

Please note though that OpenAPI schema support will be deprecated in DJA as soon as Django REST framework will deprecate it. Best take a look at#1082 for more details.

As for small fixes like this, we still integrate into DJA for the time being. I would highly recommend you though to get involved with thedrf-spectecular-json-api which will be the successor of the schema generation in the near future.

@slivercsliverc merged commit21493c1 intodjango-json-api:mainMay 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slivercslivercsliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@js-nh@sliverc
[8]ページ先頭
©2009-2025 Movatter.jp