Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added support to overwrite serializer methods in schema class#1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
n2ygk merged 1 commit intodjango-json-api:mainfromsliverc:openapi_serializer
Oct 26, 2022

Conversation

sliverc
Copy link
Member

Description of the Change

This change makes the DJA schema class compatible with the DRF change introduced withencode/django-rest-framework#7424

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name inAUTHORS

@slivercsliverc requested a review fromn2ygkOctober 26, 2022 08:47
Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thought DRF had decided to stop merging schema generator changes in lieu of recommending an external library, drf-spectacular.

@n2ygkn2ygk merged commit4e18292 intodjango-json-api:mainOct 26, 2022
@slivercsliverc deleted the openapi_serializer branchOctober 26, 2022 14:59
@sliverc
Copy link
MemberAuthor

sliverc commentedOct 27, 2022•
edited
Loading

Thanks for merging. This change actually got integrated 2 years ago and I have just recently stumbled upon it. There is a recent changeencode/django-rest-framework#7493 which will affect DJA as well, so it seems minor changes are still merged, but nothing major.

@auvipy
Copy link
Contributor

Thanks for merging. This changed actually got integrated 2 years ago and I have just recently stumbled upon it. There is a recent changeencode/django-rest-framework#7493 which will affect DJA as well, so it seems minor changes are still merged, but nothing major.

you are right, but crucial changes for thing important in DRF will also be merged. I know this from conversation with Tom Christie. DRF will deprecate core schema, but improve OpenAPI support.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@n2ygkn2ygkn2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sliverc@auvipy@n2ygk
[8]ページ先頭
©2009-2025 Movatter.jp