Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adhered to field naming format setting when generating schema#1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sliverc merged 4 commits intodjango-json-api:mainfromjokiefer:bug/fix-attribute-names
Sep 6, 2022
Merged

Adhered to field naming format setting when generating schema#1048

sliverc merged 4 commits intodjango-json-api:mainfromjokiefer:bug/fix-attribute-names
Sep 6, 2022

Conversation

jokiefer
Copy link
Contributor

@jokieferjokiefer commentedFeb 6, 2022•
edited by sliverc
Loading

Description of the Change

Added additional field name formatting which got missed out in PR#1003

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name inAUTHORS

@jokieferjokiefer changed the titlefixes attribute naming in filter backend and AutoSchemaWIP: fixes attribute naming in filter backend and AutoSchemaFeb 7, 2022
@jokieferjokiefer changed the titleWIP: fixes attribute naming in filter backend and AutoSchemafixes attribute naming in filter backend and AutoSchemaFeb 7, 2022
Copy link
Member

@slivercsliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this. Could you please also add a test which adds those cases?

I guess easiest is to extend theAuthorViewSet so it covers the cases which are fixed in this PR. The tests intest_openapi.py use snapshots so once the view has all the different cases added the snapshot only needs to be updated (pytest --snapshot-update).

@sliverc
Copy link
Member

@jokiefer Wanted to follow up whether you are still interested in working on this PR?

@slivercsliverc changed the titlefixes attribute naming in filter backend and AutoSchemaAdhered to field naming format setting when generating schemaSep 6, 2022
@sliverc
Copy link
Member

I had some time at hand and wanted to make sure that this PR lands in the next version (which is hopefully released soon, waiting for DRF to release a new version supporting Django 4.1). I added a test and made minor adjustments to the PR.

When adding the test, I noticed that there was actually an error in the code. It calledformat_field_names instead offormat_field_name so this did not work. Once again, a great example of how important tests are.

Anyway. Thanks for bringing this up and working on it.

@slivercsliverc merged commit897305c intodjango-json-api:mainSep 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slivercslivercsliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jokiefer@sliverc
[8]ページ先頭
©2009-2025 Movatter.jp