- Notifications
You must be signed in to change notification settings - Fork302
Migrate to syrupy snapshot testing#1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
auvipy approved these changesOct 28, 2021
n2ygk approved these changesNov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. Sorry for the long delay.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
snapshottest is not really maintained anymore and causes issue in showing the diff as recent versions changed ordering (see#1003). Therefore suggesting that we move tosyrupy which is well maintained, has better pytest integration, has a proper serialization format (instead of simply writing python code as snapshottest does) and is extensible.
For now this PR is a simple migration without any changes in testing. In the future also when working on#468 we might create our own syrupy extensions to simplify our testing (e.g. in test_openapi there a quite a few json.dumps).
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS