Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Adddefault_auto_field to cms/apps.py (#8254)#8258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
fsbraun wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromchore/port-forward-8254

Conversation

fsbraun
Copy link
Member

@fsbraunfsbraun commentedJun 18, 2025•
edited
Loading

  • fix: Adddefault_auto_field to cms/apps.py

  • Add default_autofield tomenus.apps

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request againstmain
  • I have added or modified the tests when changing logic
  • I have followedthe conventional commits guidelines to add meaningful information into the changelog
  • I have read thecontribution guidelines and I have joined the channel #pr-reviews on ourDiscord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Adddefault_auto_field attribute to the CMS and Menus application configurations

Bug Fixes:

  • Setdefault_auto_field = 'django.db.models.AutoField' inCMSConfig
  • Setdefault_auto_field = 'django.db.models.AutoField' inMenusConfig

* fix: Add `default_auto_field` to cms/apps.py* Add default_autofield to `menus.apss`
@sourcery-aiSourcery AI
Copy link
Contributor

sourcery-aibot commentedJun 18, 2025•
edited
Loading

Reviewer's Guide

This PR updates the application configurations for the CMS and menus apps by specifying a default primary key field type via thedefault_auto_field attribute.

Class diagram for updated AppConfig classes in cms and menus apps

classDiagram    class CMSConfig {        name = 'cms'        verbose_name = _('django CMS')        default_auto_field = 'django.db.models.AutoField'        ready()    }    class MenusConfig {        name = 'menus'        verbose_name = _('django CMS menus system')        default_auto_field = 'django.db.models.AutoField'    }    CMSConfig --|> AppConfig    MenusConfig --|> AppConfig
Loading

File-Level Changes

ChangeDetailsFiles
Introduce default_auto_field attribute to application configurations
  • Set default_auto_field = 'django.db.models.AutoField' in CMSConfig
  • Set default_auto_field = 'django.db.models.AutoField' in MenusConfig
cms/apps.py
menus/apps.py

Possibly linked issues

  • #0: PR adds default_auto_field to cms/menus apps.py, fixing missing migrations by setting primary key type.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment@sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with@sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write@sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write@sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment@sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment@sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment@sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment@sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access yourdashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-aisourcery-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey@fsbraun - I've reviewed your changes - here's some feedback:

  • Consider using django.db.models.BigAutoField instead of AutoField to align with Django 3.2+ defaults and avoid future primary key limitations.
  • For consistency, adddefault_auto_field to all other CMS-related AppConfig subclasses (e.g. placeholders, plugins).
  • There’s a typo in the PR description/commit message (“menus.apss”); update it to “menus.apps” for clarity.
Prompt for AI Agents
Please address the comments from this code review:##Overall Comments- Consider using django.db.models.BigAutoField instead of AutoField to align with Django 3.2+ defaults and avoid future primary key limitations.- For consistency, add`default_auto_field` to all other CMS-related AppConfig subclasses (e.g. placeholders, plugins).- There’s a typo in the PR description/commit message (“menus.apss”); update it to “menus.apps” for clarity.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

sourcery-ai[bot] reacted with thumbs up emojisourcery-ai[bot] reacted with thumbs down emoji
@fsbraunfsbraun marked this pull request as draftJune 18, 2025 12:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@fsbraun
[8]ページ先頭
©2009-2025 Movatter.jp