Currently the toolbar offers a menu item to delete the current page.
This is problematic, because the user first has to change into edit mode, before allowing him to delete that page.
Moreover, after deletion which page shall the browser render?

@fsbraun and I therefore discussed on Slack and concluded, that deleting a page only shall be possible through the page tree.

I have opened this pull request againstdevelop
I have added or modified the tests when changing logic
I have followedthe conventional commits guidelines to add meaningful information into the changelog
I have read thecontribution guidelines and I have joined #workgroup-pr-review onSlack to find a “pr review buddy” who is going to review my pull request.

jrief added2 commits

January 9, 2024 09:23

fix issuedjango-cms#7745

d8f73fd

discard specific verbose_name from perms_needed

remove menu item "Delete page…" from toolbar

2a7090b

As discussed with@fsbraun on Slack, pages shall exclusively be deletable through the page tree but not through the toolbar.

fsbraun changed the title~~Remove delete page from toolbar~~feat: Remove delete page from toolbar

Jan 9, 2024

fsbraun added the 4.1 label

Jan 9, 2024

Copy link

Member

fsbraun commentedJan 9, 2024

I would second the notion. Let me add my rationale:

Together with djangocms-versioning pages can never be deleted unless they do not have a single page content object or a setting is changed.
The impact of deleting a page is more transparent in the page tree: All languages and all child pages are affected. (I know all elements are shown in the confirmation dialogue - but that typically is extremely long and hard to grasp.) This is the asymmetry to the "New Page" menu entry.
It should not depend on the edit mode or publication status of the PageContent.

The alternative would be:

Only show the delete menu entry if deleting is actually possible in the setup (might be complex in relation with versioning)
Allow deleting in all edit models: preview, edit and "view on site".
Only grey out if the user lacks permissions

Merge branch 'develop-4' into remove-delete-page-from-toolbar

5a10841

Copy link

ContributorAuthor

jrief commentedJan 10, 2024

In the course of this, I would also remove the item "Duplicate this page".

Reason is, that users have no way to specify the target and hence that duplicate would end up as a sibling of the target with a slug named "copy-of-…". By allowing the create duplicates from the page tree, this problem can be avoided because normally those duplicated pages are added to a different parent anyway.

fsbraun added 5.0 and removed 4.1 labels

May 17, 2024

fsbraun added2 commits

July 29, 2024 10:43

Merge branch 'develop-4' into remove-delete-page-from-toolbar

781ee09

Merge branch 'develop-4' into remove-delete-page-from-toolbar

0d42cb4

This was referencedNov 6, 2024

feat: Improved delete page confirmation message#8070

Merged

[BUG] Can't easily delete a page that has versions#8068

Closed

Copy link

github-actionsbot commentedMay 7, 2025

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.