- Notifications
You must be signed in to change notification settings - Fork161
Improve flush-list search by avoiding skipping too many cache-keys.#120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As we're using `new_keys` to build up `flush_keys` and `search_keys`we still might need the proper keys in `obj_keys` to avoid objectsnot being invalidated properly.
EnTeQuAk commentedJun 14, 2016
This essentially replaces#106 |
coveralls commentedJun 14, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
tobiasmcnulty commentedOct 13, 2017
Hi@EnTeQuAk , my apologies for the delay on this. Is this still something you're interested in getting in? If so, could you rebase this onto master and add a test for the issue? The test suite should be passing now; if it's not for you, please let me know and I'll see what I can do to help. |
EnTeQuAk commentedOct 16, 2017
Seeing this project being active again is nice! I'll try to remember what I did and add some tests throughout this week, thanks for the follow-up! |
tobiasmcnulty commentedOct 16, 2017
Sounds good, thanks! |
dratchkov commentedNov 2, 2017
I looked at the change here vs what's in#106. I don't think this one is correct - should a flush key be hit twice, then it will end up in both the obj_keys and flush_keys. I think hitting the same flush key second time should result in a NOP, i.e. I did that by having a separate check: if key in flush_keys: |
tobiasmcnulty commentedFeb 18, 2019
Closing in favor of#127 |
Uh oh!
There was an error while loading.Please reload this page.
As we're using
new_keysto build upflush_keysandsearch_keyswe still might need the proper keys in
obj_keysto avoid objectsnot being invalidated properly.
There are some tests missing currently unfortunately but even without the patch the test-suite is failing for me locally so it's quite hard to reason about any particular changes. This should be straight forward enough though.
Let me know what you think :)