- Notifications
You must be signed in to change notification settings - Fork152
Add original_run_at to the CompletedTask model#179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This field is set to the Task.run_at on CompleatedTask creation,allowing for analysis of how long tasks are waiting in teh queue.
coveralls commentedMar 19, 2019
6 similar comments
coveralls commentedMar 19, 2019
coveralls commentedMar 19, 2019
coveralls commentedMar 19, 2019
coveralls commentedMar 19, 2019
coveralls commentedMar 19, 2019
coveralls commentedMar 19, 2019
philippeowagner commentedJul 11, 2019
Thanks for the PR and sorry for the delay. That's a good idea to track this. While reviewing I noticedthis line. I think we should review this line first. I didn't implemented these lines myself, but viewed from afar, we should just keep the original run_at there. |
schmave commentedFeb 19, 2021
I like the idea of adding original_run_at (instead of copying Task.run_at to CompletedTask.run_at as suggested by@philippeowagner), because then you can get an estimate of how long it took the task to run. I'm happy to merge conflicts here if that would be helpful to getting this merged. |
meic commentedFeb 22, 2021
Sorry for not responding sooner! To clarify my original thoughts on this:
I didn't re-use or change run_at as I didn't want to lose this information and didn't want to introduce a breaking change. If there is anything I can do to help let me know. Otherwise is@schmave is happy to merge conflicts, that would be great! |
schmave commentedMar 12, 2021
I don't have access to modify your branch, but I merged conflicts here:https://github.com/arteria/django-background-tasks/compare/master...cmu-cs-academy:original-run-at?expand=1 so you could pull from that. |
This field is set to the Task.run_at on CompletedTask creation,
allowing for analysis of how long tasks are waiting in the queue.