Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add original_run_at to the CompletedTask model#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
meic wants to merge1 commit intodjango-background-tasks:master
base:master
Choose a base branch
Loading
frommeic:original-run-at

Conversation

@meic
Copy link

This field is set to the Task.run_at on CompletedTask creation,
allowing for analysis of how long tasks are waiting in the queue.

This field is set to the Task.run_at on CompleatedTask creation,allowing for analysis of how long tasks are waiting in teh queue.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

6 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 79.048% when pulling45fcb23 on meic:original-run-at intoc97f959 on arteria:master.

@philippeowagner
Copy link

Thanks for the PR and sorry for the delay.

That's a good idea to track this.

While reviewing I noticedthis line. I think we should review this line first. I didn't implemented these lines myself, but viewed from afar, we should just keep the original run_at there.

@schmave
Copy link

I like the idea of adding original_run_at (instead of copying Task.run_at to CompletedTask.run_at as suggested by@philippeowagner), because then you can get an estimate of how long it took the task to run. I'm happy to merge conflicts here if that would be helpful to getting this merged.

@meic
Copy link
Author

Sorry for not responding sooner!

To clarify my original thoughts on this:

  • run_at (as it currently stands) is useful to understand how long a background task took to execute
  • original_run_at (the new field) is useful to know how long after it was scheduled to run, that it actually ran

I didn't re-use or change run_at as I didn't want to lose this information and didn't want to introduce a breaking change.

If there is anything I can do to help let me know. Otherwise is@schmave is happy to merge conflicts, that would be great!

@schmave
Copy link

I don't have access to modify your branch, but I merged conflicts here:https://github.com/arteria/django-background-tasks/compare/master...cmu-cs-academy:original-run-at?expand=1 so you could pull from that.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@meic@coveralls@philippeowagner@schmave@meicwilliams

[8]ページ先頭

©2009-2025 Movatter.jp