- Notifications
You must be signed in to change notification settings - Fork21
Perf #36439 -- Added performance benchmark foracheck_password hashing via asyncio#94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
roelzkie15 wants to merge1 commit intodjango:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+98 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 tasks
27c72d2 to47829a5Compare…tion using different password hasher. This is related todjango/django/pull/19611
47829a5 to61e8967CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This performance benchmark was added as part of thedjango/django/pull/19611 as requested by the reviewer.
Setup
Using the following
asv.config.jsonfile:{"version":1,"project":"Django","project_url":"https://www.djangoproject.com/","repo":"https://github.com/roelzkie15/django.git","branches": ["main"],"build_command": ["python -m pip install build bcrypt argon2-cffi","python -m build --wheel -o {build_cache_dir} {build_dir}" ],"environment_type":"conda","show_commit_url":"https://github.com/roelzkie15/django/commit/","pythons": ["3.12","3.13"]}You may also use
virtualenvfor theenvironment_type, just make sure you're in a virtual environment.Collecting data
Getting the result of the
mainbranch (HEAD).Getting the result of thepull request's branch
fix-36439-auth-hashing-performance.Then compare the benchmark:
Result output from my benchmark: