- Notifications
You must be signed in to change notification settings - Fork55
Renamed "patch" to "pull request"#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Django hasn't used patches in earnest in probablya decade, it's time to move on with the reality.
I suppose we'll need to adjust all the contribution documentation as well though? |
Yes, definitely. I would like to see how things look like on my local version, then I'll file a PR for django/django. I'm putting the "on hold" tag on this for now. (and thanks for you review by the way, I appreciate it ✨ ) |
For reference, the corresponding docs changes are tracked inhttps://code.djangoproject.com/ticket/35894#ticket |
| has_patch.order = 20 | ||
| needs_better_patch = checkbox | ||
| needs_better_patch.label =Patch needs improvement | ||
| needs_better_patch.label =Pull request needs improvement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| needs_better_patch.label =Pull request needs improvement | |
| needs_better_patch.label =Requested changes |
maybe
nessita left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@bmispelon for starting this crusade!
I have commented on the ticket but I really think that we should not use a platform-dependent terminology (Pull Request is a GitHub specific term). I would suggest:
- "Has proposal"
- "Has fix"
- "Has solution"
(I prefer the first one, since some proposal are not a fix nor a complete solution.)
And then: "Needs improvement" directly, considering that the other flags are "Needs docs" and "Needs tests".
Thanks for the feedback on this merge request! 🙃 I like your idea of "Needs improvement": it's shorter and matches the other two flags better. As I wroteon Trac, I disagree your other point (and "proposal" seems too imprecise for me, plus it could be confused for the "P" of "DEP"). |
@bmispelon there are a lot of wording tweaks here that seem like they improve the clarity of the UI quite a bit. Should we look into getting those in? I see you labelled this "on hold", I assume the labels of the fields needs a lot of careful thought as the more stable the labels are the better. But for the "help text" type content of tickethacks.js, feels like we can always make more tweaks later? |
The "on hold" label refers to the fact that this ticket depends on changes being accepted in thecontributor documentation on django/django. The changes I proposed there were met with conservatism that I found unwarranted, and I lost the appetite to contribute further as a result. I don't think this ticket can move further until the discussion is resolved on the django/django issue, but that seems to be at a standstill right now. |
Django hasn't used patches in earnest in probably
a decade, it's time to move on with the reality.