Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Proposal] Add sponsor Django banner to Trac#143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sarahboyce wants to merge2 commits intodjango:main
base:main
Choose a base branch
Loading
fromsarahboyce:sponsor-django

Conversation

sarahboyce
Copy link
Contributor

Desktop:
image

Mobile:
Screenshot from 2023-08-11 22-59-49

tim-schilling reacted with heart emoji
@tim-schilling
Copy link
Member

@sarahboyce have you considered putting this text below the block of "Please read this first"? We definitely want to make it easier to find our donate button(s), but I suspect we still want the focus of this page to be on how to create a ticket for Django. Pushing that down is counter productive to the main purpose of the page.

Would it be possible to render this on the initial render of the issue after it's been created too?

@sarahboyce
Copy link
ContributorAuthor

Updated images based off new shortened wording:
short-desktop
short-mobile

have you considered putting this text below the block of "Please read this first"?

@tim-schilling the banner would be on all the Trac pages (not just the new ticket page) and the "Please read this first" I think is still promeninent as it's before you can submit 🤔 Now the wording is shorter do you still feel the same? If we're worried I can hide the banner on the New ticket page and only show it on the detail and list pages?

@sarahboycesarahboyce marked this pull request as ready for reviewAugust 23, 2023 17:42
@tim-schilling
Copy link
Member

Now the wording is shorter do you still feel the same? If we're worried I can hide the banner on the New ticket page and only show it on the detail and list pages?

@sarahboyce with the shorter wording it's not a concern. Thank you for taking it into consideration!

sarahboyce reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sarahboyce@tim-schilling

[8]ページ先頭

©2009-2025 Movatter.jp